update tests

Author: LukasAud

spec/acceptance/deferred_spec.rb

@@ -1,38 +1,33 @@
+# spec/acceptance/deferred_spec.rb
 # frozen_string_literal: true
-
 require 'spec_helper_acceptance'
 
-describe 'deferred values with dsc_lite' do
-  let(:control_manifest) do
-    File.read(File.join(__dir__, '..', 'fixtures', 'manifests', '01_file_deferred.pp'))
-  end
-
-  let(:dsc_deferred_direct) do
-    File.read(File.join(__dir__, '..', 'fixtures', 'manifests', '02_dsc_deferred_direct.pp'))
-  end
+def read_fixture(name)
+  File.read(File.join(__dir__, '..', 'fixtures', 'manifests', name))
+end
 
-  let(:dsc_deferred_var) do
-    File.read(File.join(__dir__, '..', 'fixtures', 'manifests', '03_dsc_deferred_in_variable.pp'))
-  end
+describe 'deferred values with dsc_lite' do
+  let(:control_manifest) { read_fixture('01_file_deferred.pp') }
+  let(:dsc_deferred_direct) { read_fixture('02_dsc_deferred_direct.pp') }
+  let(:dsc_deferred_var) { read_fixture('03_dsc_deferred_in_variable.pp') }
 
   it 'applies with native file + deferred (control succeeds)' do
     idempotent_apply(control_manifest)
-    # optionally verify file contents
     on(default, 'powershell.exe -NoProfile -NonInteractive -Command "(Get-Content -Raw C:/Temp/deferred_ok.txt)"') do |r|
-      expect(r.stdout).to match(%r{hello-world})
+      expect(r.stdout).to match(/hello-world/)
     end
   end
 
   context 'dsc_lite with deferred' do
     it 'fails when passing Deferred directly to a DSC property' do
-      # We currently expect failure (documenting the bug).
       result = apply_manifest(dsc_deferred_direct, expect_failures: true)
-      expect(result.stderr + result.stdout).to match(%r{Deferred|serialize|to_json|downcase|implicit conversion}i)
+      # broad match: we only assert that a Deferred/serialization-like error occurs
+      expect(result.stderr + result.stdout).to match(/Deferred|serialize|to_json|implicit conversion|TypeError|cannot/i)
     end
 
     it 'fails when assigning Deferred to a variable then to a DSC property' do
       result = apply_manifest(dsc_deferred_var, expect_failures: true)
-      expect(result.stderr + result.stdout).to match(%r{Deferred|serialize|to_json|downcase|implicit conversion}i)
+      expect(result.stderr + result.stdout).to match(/Deferred|serialize|to_json|implicit conversion|TypeError|cannot/i)
     end
   end
-end
+end

spec/fixtures/manifests/01_file_deferred.pp

@@ -1,5 +1,10 @@
-# manifest: 01_file_deferred.pp
+# 01_file_deferred.pp
+file { 'C:/Temp':
+  ensure => directory,
+}
+
 file { 'C:/Temp/deferred_ok.txt':
   ensure  => file,
   content => Deferred('join', [['hello','-','world'], '']),
+  require => File['C:/Temp'],
 }

spec/fixtures/manifests/02_dsc_deferred_direct.pp

@@ -1,11 +1,16 @@
-# manifest: 02_dsc_deferred_direct.pp
+# 02_dsc_deferred_direct.pp
+file { 'C:/Temp':
+  ensure => directory,
+}
+
 dsc { 'WriteFileViaDSC':
-  dsc_resource_name => 'File',
-  dsc_module        => 'PSDesiredStateConfiguration',
-  properties        => {
-    'DestinationPath' => 'C:\Temp\from_dsc.txt',
-    'Type'            => 'File',
-    'Ensure'          => 'Present',
-    'Contents'        => Deferred('join', [['hello','-','dsc'], '']),
+  resource_name => 'File',
+  module        => 'PSDesiredStateConfiguration',
+  properties    => {
+    DestinationPath => 'C:\Temp\from_dsc.txt',
+    Type            => 'File',
+    Ensure          => 'Present',
+    Contents        => Deferred('join', [['hello','-','dsc'], '']),
   },
+  require => File['C:/Temp'],
 }

spec/fixtures/manifests/03_dsc_deferred_in_variable.pp

@@ -1,13 +1,18 @@
-# manifest: 03_dsc_deferred_in_variable.pp
+# 03_dsc_deferred_in_variable.pp
+file { 'C:/Temp':
+  ensure => directory,
+}
+
 $value = Deferred('join', [['hello','-','var'], ''])
 
 dsc { 'WriteFileViaDSCVar':
-  dsc_resource_name => 'File',
-  dsc_module        => 'PSDesiredStateConfiguration',
-  properties        => {
-    'DestinationPath' => 'C:\Temp\from_dsc_var.txt',
-    'Type'            => 'File',
-    'Ensure'          => 'Present',
-    'Contents'        => $value,  # still a Deferred wrapper at this point
+  resource_name => 'File',
+  module        => 'PSDesiredStateConfiguration',
+  properties    => {
+    DestinationPath => 'C:\Temp\from_dsc_var.txt',
+    Type            => 'File',
+    Ensure          => 'Present',
+    Contents        => $value, # still a Deferred wrapper
   },
+  require => File['C:/Temp'],
 }