Merge pull request #224 from puppetlabs/MAINT-Addressing_undetected_legacy_facts

(MAINT) Addressing undetected legacy facts

Author: gavindidrichsen

lib/puppet/provider/base_dsc_lite/powershell.rb

@@ -6,8 +6,8 @@
 
 Puppet::Type.type(:base_dsc_lite).provide(:powershell) do
   confine feature: :pwshlib
-  confine operatingsystem: :windows
-  defaultfor operatingsystem: :windows
+  confine 'os.name' => :windows
+  defaultfor 'os.name' => :windows
 
   commands powershell: (if File.exist?("#{ENV.fetch('SYSTEMROOT', nil)}\\sysnative\\WindowsPowershell\\v1.0\\powershell.exe")
                           "#{ENV.fetch('SYSTEMROOT', nil)}\\sysnative\\WindowsPowershell\\v1.0\\powershell.exe"

lib/puppet/type/dsc.rb

@@ -124,7 +124,7 @@ def change_to_s(currentvalue, newvalue)
       Provider for dsc type
   DOC
   confine feature: :dsc_lite
-  defaultfor operatingsystem: :windows
+  defaultfor 'os.name' => :windows
 
   mk_resource_methods
 end

spec/fixtures/dsc_puppetfakeresource/dsc_puppetfakeresource.rb

@@ -127,7 +127,7 @@ def builddepends
 
 Puppet::Type.type(:dsc_puppetfakeresource).provide :powershell, :parent => Puppet::Type.type(:base_dsc_lite).provider(:powershell) do
   confine :feature => :dsc_lite
-  defaultfor :operatingsystem => :windows
+  defaultfor 'os.name' => :windows
 
   mk_resource_methods
 end