(CAT-2281) Remove puppet 7 infrastructure #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavindidrichsen
requested changes
Apr 10, 2025
Contributor
gavindidrichsen
left a comment
gavindidrichsen
left a comment
There was a problem hiding this comment.
Hi @LukasAud . If you're removing the workflow restarter on this, then you can probably remove https://github.com/puppetlabs/puppetlabs-dsc_lite/blob/CAT-2281-Remove_puppet_7_test_infrastructure/.github/workflows/workflow-restarter.yml too
Contributor
Author
Actually, I have not the slightest idea how that got in there. I don't recall removing the workflow restarter at all as it's not a part of this work piece. Let me fix that. |
LukasAud
force-pushed
the
CAT-2281-Remove_puppet_7_test_infrastructure
branch
from
f56b5ad to
ce9ed6a
Compare
LukasAud
force-pushed
the
CAT-2281-Remove_puppet_7_test_infrastructure
branch
from
ce9ed6a to
b6f86a0
Compare
jordanbreen28
approved these changes
Apr 11, 2025
gavindidrichsen
approved these changes
Apr 11, 2025
gavindidrichsen
deleted the
CAT-2281-Remove_puppet_7_test_infrastructure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 7 is EOL. Therefore, we can remove the test infrastructure for it. This PR aims to clear up any testing/config infrastructure related to Puppet 7 and, by extension, Ruby 2.7.