parameter datatypes

Author: LukasAud

.puppet-lint.rc

@@ -1,2 +1 @@
 --relative
---no-parameter_types-check

.sync.yml

@@ -32,6 +32,3 @@ spec/spec_helper.rb:
 .travis.yml:
   delete: true
 changelog_since_tag: 'v3.0.0'
-Rakefile:
-  extra_disabled_lint_checks:
-    - parameter_types

Rakefile

@@ -42,7 +42,6 @@ def changelog_future_release
 end
 
 PuppetLint.configuration.send('disable_relative')
-PuppetLint.configuration.send('disable_parameter_types')
 
 
 if Bundler.rubygems.find_name('github_changelog_generator').any?

manifests/init.pp

@@ -31,13 +31,13 @@
 #   Controls whether puppet manages the ebtables package or not. If managed, the package will use the value of pkg_ensure.
 #
 class firewall (
-  $ensure          = running,
-  $ensure_v6       = undef,
-  $pkg_ensure      = present,
-  $service_name    = $firewall::params::service_name,
-  $service_name_v6 = $firewall::params::service_name_v6,
-  $package_name    = $firewall::params::package_name,
-  $ebtables_manage = false,
+  Enum[running, stopped, 'running', 'stopped']           $ensure          = running,
+  Optional[Enum[running, stopped, 'running', 'stopped']] $ensure_v6       = undef,
+  Enum[present, latest, 'present', 'latest']             $pkg_ensure      = present,
+  Variant[String[1], Array[String[1]]]                   $service_name    = $firewall::params::service_name,
+  Optional[String[1]]                                    $service_name_v6 = $firewall::params::service_name_v6,
+  Optional[Variant[String[1], Array[String[1]]]]         $package_name    = $firewall::params::package_name,
+  Boolean                                                $ebtables_manage = false,
 ) inherits firewall::params {
   $_ensure_v6 = pick($ensure_v6, $ensure)
 

manifests/linux.pp

@@ -24,14 +24,14 @@
 # @api private
 #
 class firewall::linux (
-  $ensure          = running,
-  $ensure_v6       = undef,
-  $pkg_ensure      = installed,
-  $service_name    = $firewall::params::service_name,
-  $service_name_v6 = $firewall::params::service_name_v6,
-  $package_name    = $firewall::params::package_name,
-  $ebtables_manage = false,
-  $iptables_name   = $firewall::params::iptables_name,
+  Enum[running, stopped, 'running', 'stopped']           $ensure          = running,
+  Optional[Enum[running, stopped, 'running', 'stopped']] $ensure_v6       = undef,
+  Enum[installed, latest, 'installed', 'latest']         $pkg_ensure      = installed,
+  Variant[String[1], Array[String[1]]]                   $service_name    = $firewall::params::service_name,
+  Optional[String[1]]                                    $service_name_v6 = $firewall::params::service_name_v6,
+  Optional[Variant[String[1], Array[String[1]]]]         $package_name    = $firewall::params::package_name,
+  Boolean                                                $ebtables_manage = false,
+  String[1]                                              $iptables_name   = $firewall::params::iptables_name,
 ) inherits firewall::params {
   $enable = $ensure ? {
     'running' => true,

manifests/linux/archlinux.pp

@@ -19,11 +19,11 @@
 # @api private
 #
 class firewall::linux::archlinux (
-  $ensure         = 'running',
-  $enable         = true,
-  $service_name   = $firewall::params::service_name,
-  $package_name   = $firewall::params::package_name,
-  $package_ensure = $firewall::params::package_ensure,
+  Enum[running, stopped, 'running', 'stopped']   $ensure         = 'running',
+  Boolean                                        $enable         = true,
+  Variant[String[1], Array[String[1]]]           $service_name   = $firewall::params::service_name,
+  Optional[Variant[String[1], Array[String[1]]]] $package_name   = $firewall::params::package_name,
+  Enum[present, latest, 'present', 'latest']     $package_ensure = $firewall::params::package_ensure,
 ) inherits firewall::params {
   if $package_name {
     package { $package_name:

manifests/linux/debian.pp

@@ -19,11 +19,11 @@
 # @api private
 #
 class firewall::linux::debian (
-  $ensure         = running,
-  $enable         = true,
-  $service_name   = $firewall::params::service_name,
-  $package_name   = $firewall::params::package_name,
-  $package_ensure = $firewall::params::package_ensure,
+  Enum[running, stopped, 'running', 'stopped']   $ensure         = running,
+  Boolean                                        $enable         = true,
+  Variant[String[1], Array[String[1]]]           $service_name   = $firewall::params::service_name,
+  Optional[Variant[String[1], Array[String[1]]]] $package_name   = $firewall::params::package_name,
+  Enum[present, latest, 'present', 'latest']     $package_ensure = $firewall::params::package_ensure,
 ) inherits firewall::params {
   if $package_name {
     ensure_packages([$package_name], {

manifests/linux/gentoo.pp

@@ -19,11 +19,11 @@
 # @api private
 #
 class firewall::linux::gentoo (
-  $ensure         = 'running',
-  $enable         = true,
-  $service_name   = $firewall::params::service_name,
-  $package_name   = $firewall::params::package_name,
-  $package_ensure = $firewall::params::package_ensure,
+  Enum[running, stopped, 'running', 'stopped']   $ensure         = running,
+  Boolean                                        $enable         = true,
+  Variant[String[1], Array[String[1]]]           $service_name   = $firewall::params::service_name,
+  Optional[Variant[String[1], Array[String[1]]]] $package_name   = $firewall::params::package_name,
+  Enum[present, latest, 'present', 'latest']     $package_ensure = $firewall::params::package_ensure,
 ) inherits firewall::params {
   if $package_name {
     package { $package_name:

manifests/linux/redhat.pp

@@ -32,16 +32,16 @@
 # @api private
 #
 class firewall::linux::redhat (
-  $ensure           = running,
-  $ensure_v6        = undef,
-  $enable           = true,
-  $enable_v6        = undef,
-  $service_name     = $firewall::params::service_name,
-  $service_name_v6  = $firewall::params::service_name_v6,
-  $package_name     = $firewall::params::package_name,
-  $package_ensure   = $firewall::params::package_ensure,
-  $sysconfig_manage = $firewall::params::sysconfig_manage,
-  $firewalld_manage = $firewall::params::firewalld_manage,
+  Enum[running, stopped, 'running', 'stopped']           $ensure           = running,
+  Optional[Enum[running, stopped, 'running', 'stopped']] $ensure_v6        = undef,
+  Boolean                                                $enable           = true,
+  Optional[Boolean]                                      $enable_v6        = undef,
+  Variant[String[1], Array[String[1]]]                   $service_name     = $firewall::params::service_name,
+  Optional[String[1]]                                    $service_name_v6  = $firewall::params::service_name_v6,
+  Optional[Variant[String[1], Array[String[1]]]]         $package_name     = $firewall::params::package_name,
+  Enum[present, latest, 'present', 'latest']             $package_ensure   = $firewall::params::package_ensure,
+  Boolean                                                $sysconfig_manage = $firewall::params::sysconfig_manage,
+  Boolean                                                $firewalld_manage = $firewall::params::firewalld_manage,
 ) inherits firewall::params {
   $_ensure_v6 = pick($ensure_v6, $ensure)
   $_enable_v6 = pick($enable_v6, $enable)