(maint) Rubocop Fix

Author: david22swan

.rubocop_todo.yml

@@ -1,56 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-08-29 15:26:08 UTC using RuboCop version 1.48.1.
+# on 2025-07-01 09:21:38 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 20
-# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
-Metrics/AbcSize:
-  Max: 270
-
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
-# AllowedMethods: refine
-Metrics/BlockLength:
-  Max: 127
-
-# Offense count: 3
-# Configuration parameters: CountComments, CountAsOne.
-Metrics/ClassLength:
-  Max: 776
-
-# Offense count: 17
-# Configuration parameters: AllowedMethods, AllowedPatterns.
-Metrics/CyclomaticComplexity:
-  Max: 122
-
-# Offense count: 20
-# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
-Metrics/MethodLength:
-  Max: 135
-
-# Offense count: 12
-# Configuration parameters: AllowedMethods, AllowedPatterns.
-Metrics/PerceivedComplexity:
-  Max: 122
-
-# Offense count: 18
-# Configuration parameters: IgnoredMetadata.
-RSpec/DescribeClass:
-  Enabled: false
-
-# Offense count: 9
-# Configuration parameters: CountAsOne.
-RSpec/ExampleLength:
-  Max: 8
-
-# Offense count: 41
-RSpec/MultipleExpectations:
-  Max: 2
-
 # Offense count: 38
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
@@ -60,31 +15,9 @@ RSpec/NamedSubject:
     - 'spec/unit/classes/firewall_linux_debian_spec.rb'
     - 'spec/unit/classes/firewall_linux_redhat_spec.rb'
 
-# Offense count: 38
-# Configuration parameters: AllowedGroups.
-RSpec/NestedGroups:
-  Max: 5
-
-# Offense count: 43
-# Configuration parameters: AllowedPatterns.
-# AllowedPatterns: ^expect_, ^assert_
-RSpec/NoExpectationExample:
-  Exclude:
-    - 'spec/acceptance/class_spec.rb'
-    - 'spec/acceptance/firewall_attributes_exceptions_spec.rb'
-    - 'spec/acceptance/firewall_attributes_ipv6_exceptions_spec.rb'
-    - 'spec/acceptance/firewallchain_spec.rb'
-    - 'spec/acceptance/rules_spec.rb'
-    - 'spec/acceptance/standard_usage_spec.rb'
-
-# Offense count: 83
+# Offense count: 85
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
   Exclude:
     - 'lib/puppet/provider/firewall/firewall.rb'
     - 'lib/puppet/provider/firewallchain/firewallchain.rb'
-
-# Offense count: 1
-Style/MixinUsage:
-  Exclude:
-    - 'spec/spec_helper.rb'

spec/unit/puppet/provider/firewall/firewall_public_spec.rb

@@ -62,7 +62,7 @@
         },
       ].each do |test|
         it "updates the resource: '#{test[:should][:name]}'" do
-          expect(context).to receive(:notice).with(%r{\Updating Rule '#{test[:should][:name]}'})
+          expect(context).to receive(:notice).with(%r{Updating Rule '#{test[:should][:name]}'})
           allow(described_class).to receive(:insert_order)
             .with(context, test[:should][:name], test[:should][:chain], test[:should][:table], test[:should][:protocol]).and_return(1)
           allow(described_class).to receive(:hash_to_rule)