Package_Name param was used in a clever way, moved to iptables_name

Author: adamboutcher

manifests/linux.pp

@@ -31,6 +31,7 @@
   $service_name_v6 = $firewall::params::service_name_v6,
   $package_name    = $firewall::params::package_name,
   $ebtables_manage = false,
+  $iptables_name   = $firewall::params::iptables_name,
 ) inherits ::firewall::params {
   $enable = $ensure ? {
     'running' => true,
@@ -45,7 +46,7 @@
   }
 
   package { 'iptables':
-    name   => $package_name,
+    name   => $iptables_name,
     ensure => $pkg_ensure,
   }
 

manifests/params.pp

@@ -11,16 +11,20 @@
           $service_name = 'iptables'
           $service_name_v6 = 'ip6tables'
           $package_name = undef
+          $iptables_name = 'iptables'
           $sysconfig_manage = true
         }
         'Fedora': {
           $service_name = 'iptables'
           $service_name_v6 = 'ip6tables'
           if versioncmp($::operatingsystemrelease, '34') >= 0 {
-            $package_name = 'iptables-compat'
+            $package_name = 'iptables-services'
+            $iptables_name = 'iptables-compat'
           } elsif versioncmp($::operatingsystemrelease, '15') >= 0 {
             $package_name = 'iptables-services'
+            $iptables_name = 'iptables'
           } else {
+            $iptables_name = 'iptables'
             $package_name = undef
           }
           $sysconfig_manage = true
@@ -30,23 +34,27 @@
             $service_name = ['iptables', 'nftables']
             $service_name_v6 = 'ip6tables'
             $package_name = ['iptables-services', 'nftables']
+            $iptables_name = 'iptables'
             $sysconfig_manage = false
           } elsif versioncmp($::operatingsystemrelease, '7.0') >= 0 {
             $service_name = 'iptables'
             $service_name_v6 = 'ip6tables'
             $package_name = 'iptables-services'
+            $iptables_name = 'iptables'
             $sysconfig_manage = true
           } else {
             $service_name = 'iptables'
             $service_name_v6 = 'ip6tables'
             $package_name = 'iptables-ipv6'
+            $iptables_name = 'iptables'
             $sysconfig_manage = true
           }
         }
       }
     }
     'Debian': {
       $service_name_v6 = undef
+      $iptables_name = 'iptables'
       case $::operatingsystem {
         'Debian': {
           if versioncmp($::operatingsystemrelease, 'unstable') >= 0 {
@@ -81,6 +89,7 @@
       $package_name = 'net-firewall/iptables'
     }
     default: {
+      $iptables_name = 'iptables'
       $service_name_v6 = undef
       case $::operatingsystem {
         'Archlinux': {