(CONT-352) Syntax update

Code now compliant with rules regarding:

legacy facts

Author: LukasAud

.puppet-lint.rc

@@ -2,4 +2,3 @@
 --no-relative_classname_inclusion-check
 --no-parameter_types-check
 --no-top_scope_facts-check
---no-legacy_facts-check

.sync.yml

@@ -37,4 +37,3 @@ Rakefile:
     - relative_classname_inclusion
     - parameter_types
     - top_scope_facts
-    - legacy_facts

Rakefile

@@ -45,7 +45,6 @@ PuppetLint.configuration.send('disable_relative')
 PuppetLint.configuration.send('disable_relative_classname_inclusion')
 PuppetLint.configuration.send('disable_parameter_types')
 PuppetLint.configuration.send('disable_top_scope_facts')
-PuppetLint.configuration.send('disable_legacy_facts')
 
 
 if Bundler.rubygems.find_name('github_changelog_generator').any?

manifests/linux.pp

@@ -56,7 +56,7 @@
     }
   }
 
-  case $::operatingsystem {
+  case $facts['os']['name'] {
     'RedHat', 'CentOS', 'Fedora', 'Scientific', 'SL', 'SLC', 'Ascendos',
     'CloudLinux', 'PSBM', 'OracleLinux', 'OVS', 'OEL', 'Amazon', 'XenServer',
     'VirtuozzoLinux', 'Rocky', 'AlmaLinux': {

manifests/linux/redhat.pp

@@ -49,7 +49,7 @@
   # RHEL 7 / CentOS 7 and later and Fedora 15 and later require the iptables-services
   # package, which provides the /usr/libexec/iptables/iptables.init used by
   # lib/puppet/util/firewall.rb.
-  if ($::operatingsystem != 'Amazon') {
+  if ($facts['os']['name'] != 'Amazon') {
     if $firewalld_manage {
       service { 'firewalld':
         ensure => stopped,
@@ -72,7 +72,7 @@
     )
   }
 
-  if ($::operatingsystem != 'Amazon') {
+  if ($facts['os']['name'] != 'Amazon') {
     if $ensure == 'running' {
       $running_command = ['/usr/bin/systemctl', 'daemon-reload']
 
@@ -86,8 +86,8 @@
     }
   }
 
-  if ($::operatingsystem == 'Amazon') and (versioncmp($::operatingsystemmajrelease, '4') >= 0)
-  or ($::operatingsystem == 'Amazon') and (versioncmp($::operatingsystemmajrelease, '2') >= 0) {
+  if ($facts['os']['name'] == 'Amazon') and (versioncmp($facts['os']['release']['major'], '4') >= 0)
+  or ($facts['os']['name'] == 'Amazon') and (versioncmp($facts['os']['release']['major'], '2') >= 0) {
     service { $service_name:
       ensure    => $ensure,
       enable    => $enable,
@@ -135,12 +135,12 @@
 
     # Redhat 7 selinux user context for /etc/sysconfig/iptables is set to system_u
     # Redhat 7 selinux type context for /etc/sysconfig/iptables is set to system_conf_t
-    case $::selinux {
+    case $facts['os']['selinux']['enabled'] {
       #lint:ignore:quoted_booleans
       'true',true: {
-        case $::operatingsystem {
+        case $facts['os']['name'] {
           'CentOS': {
-            case $::operatingsystemrelease {
+            case $facts['os']['release']['full'] {
               /^6\..*/: {
                 $seluser = 'unconfined_u'
                 $seltype = 'system_conf_t'

manifests/params.pp

@@ -4,9 +4,9 @@
 #
 class firewall::params {
   $package_ensure = 'present'
-  case $::osfamily {
+  case $facts['os']['family'] {
     'RedHat': {
-      case $::operatingsystem {
+      case $facts['os']['name'] {
         'Amazon': {
           $service_name = 'iptables'
           $service_name_v6 = 'ip6tables'
@@ -18,7 +18,7 @@
         'Fedora': {
           $service_name = 'iptables'
           $service_name_v6 = 'ip6tables'
-          if versioncmp($::operatingsystemrelease, '34') >= 0 {
+          if versioncmp($facts['os']['release']['full'], '34') >= 0 {
             $package_name = 'iptables-services'
             $iptables_name = 'iptables-compat'
           } else {
@@ -29,21 +29,21 @@
           $firewalld_manage = true
         }
         default: {
-          if versioncmp($::operatingsystemrelease, '9') >= 0 {
+          if versioncmp($facts['os']['release']['full'], '9') >= 0 {
             $service_name = ['nftables','iptables']
             $service_name_v6 = 'ip6tables'
             $package_name = ['iptables-services', 'nftables', 'iptables-nft-services']
             $iptables_name = 'iptables-nft'
             $sysconfig_manage = false
             $firewalld_manage = false
-          } elsif versioncmp($::operatingsystemrelease, '8.0') >= 0 {
+          } elsif versioncmp($facts['os']['release']['full'], '8.0') >= 0 {
             $service_name = ['iptables', 'nftables']
             $service_name_v6 = 'ip6tables'
             $package_name = ['iptables-services', 'nftables']
             $iptables_name = 'iptables'
             $sysconfig_manage = false
             $firewalld_manage = true
-          } elsif versioncmp($::operatingsystemrelease, '7.0') >= 0 {
+          } elsif versioncmp($facts['os']['release']['full'], '7.0') >= 0 {
             $service_name = 'iptables'
             $service_name_v6 = 'ip6tables'
             $package_name = 'iptables-services'
@@ -64,12 +64,12 @@
     'Debian': {
       $service_name_v6 = undef
       $iptables_name = 'iptables'
-      case $::operatingsystem {
+      case $facts['os']['name'] {
         'Debian': {
-          if versioncmp($::operatingsystemrelease, 'unstable') >= 0 {
+          if versioncmp($facts['os']['release']['full'], 'unstable') >= 0 {
             $service_name = 'netfilter-persistent'
             $package_name = 'netfilter-persistent'
-          } elsif versioncmp($::operatingsystemrelease, '8.0') >= 0 {
+          } elsif versioncmp($facts['os']['release']['full'], '8.0') >= 0 {
             $service_name = 'netfilter-persistent'
             $package_name = 'iptables-persistent'
           } else {
@@ -78,7 +78,7 @@
           }
         }
         'Ubuntu': {
-          if versioncmp($::operatingsystemrelease, '14.10') >= 0 {
+          if versioncmp($facts['os']['release']['full'], '14.10') >= 0 {
             $service_name = 'netfilter-persistent'
             $package_name = 'iptables-persistent'
           } else {
@@ -100,7 +100,7 @@
     default: {
       $iptables_name = 'iptables'
       $service_name_v6 = undef
-      case $::operatingsystem {
+      case $facts['os']['name'] {
         'Archlinux': {
           $service_name = ['iptables','ip6tables']
           $package_name = undef

spec/spec_helper_local.rb

@@ -33,9 +33,11 @@ def with_debian_facts
   let :facts do
     {
       kernel: 'Linux',
-      operatingsystem: 'Debian',
-      operatingsystemrelease: '8.0',
-      osfamily: 'Debian',
+      os: {
+        name: 'Debian',
+        release: { full: '8.0' },
+        family: 'Debian',
+      },
     }
   end
 end

spec/unit/classes/firewall_linux_archlinux_spec.rb

@@ -5,8 +5,10 @@
 describe 'firewall::linux::archlinux', type: :class do
   let(:facts) do
     {
-      osfamily: 'Archlinux',
-      operatingsystem: 'Archlinux',
+      os: {
+        family: 'ArchLinux',
+        name: 'ArchLinux',
+      },
     }
   end
 

spec/unit/classes/firewall_linux_debian_spec.rb

@@ -6,9 +6,11 @@
   context 'with Debian 10' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: '10.0',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: '10.0' },
+        },
       }
     end
 
@@ -29,9 +31,11 @@
   context 'with Debian 10, enable => false' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: '10',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: '10' },
+        },
       }
     end
     let(:params) { { enable: 'false' } }
@@ -46,9 +50,11 @@
   context 'with Debian 10, ensure => stopped' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: '10.0',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: '10.0' },
+        },
       }
     end
     let(:params) { { ensure: 'stopped' } }
@@ -63,9 +69,11 @@
   context 'with Debian 11' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: '11.0',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: '11.0' },
+        },
       }
     end
 
@@ -86,9 +94,11 @@
   context 'with Debian 11, enable => false' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: '11',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: '11' },
+        },
       }
     end
     let(:params) { { enable: 'false' } }
@@ -103,9 +113,11 @@
   context 'with Debian 11, ensure => stopped' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: '10.0',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: '10.0' },
+        },
       }
     end
     let(:params) { { ensure: 'stopped' } }
@@ -120,9 +132,11 @@
   context 'with Debian unstable' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: 'unstable',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: 'unstable' },
+        },
       }
     end
 
@@ -143,9 +157,11 @@
   context 'with Debian unstable, enable => false' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: 'unstable',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: 'unstable' },
+        },
       }
     end
     let(:params) { { enable: 'false' } }
@@ -160,9 +176,11 @@
   context 'with Debian unstable, ensure => stopped' do
     let(:facts) do
       {
-        osfamily: 'Debian',
-        operatingsystem: 'Debian',
-        operatingsystemrelease: '10.0',
+        os: {
+          family: 'Debian',
+          name: 'Debian',
+          release: { full: '10.0' },
+        },
       }
     end
     let(:params) { { ensure: 'stopped' } }

spec/unit/classes/firewall_linux_redhat_spec.rb

@@ -42,10 +42,12 @@
       context "os #{os} and osrel #{osrel}" do
         let(:facts) do
           {
-            operatingsystem: os,
-            operatingsystemrelease: osrel,
-            osfamily: 'RedHat',
-            selinux: false,
+            os: {
+              name: os,
+              release: { full: osrel },
+              family: 'RedHat',
+              selinux: { enabled: false },
+            },
             puppetversion: Puppet.version,
           }
         end
@@ -130,10 +132,12 @@
       context "os #{os} and osrel #{osrel}" do
         let(:facts) do
           {
-            operatingsystem: os,
-            operatingsystemrelease: osrel,
-            osfamily: 'RedHat',
-            selinux: false,
+            os: {
+              name: os,
+              release: { full: osrel },
+              family: 'RedHat',
+              selinux: { enabled: false },
+            },
             puppetversion: Puppet.version,
           }
         end