(CAT-761) Implement acceptance testing of purge and associated attributes ignore/ignore_foreign

- Updates `ignore` to compare against firewall read only attribute `line` rather than `name` as it allows for a greater degree of control.
- Contains small updates to other acceptance tests.

Author: david22swan

lib/puppet/provider/firewallchain/firewallchain.rb

@@ -189,7 +189,7 @@ def generate(_context, title, _is, should)
     # Remove rules which match our ignore filter
     # Ensure ignore value is wrapped as an array to simplify the code
     should[:ignore] = [should[:ignore]] if should[:ignore].is_a?(String)
-    rules_resources.delete_if { |resource| should[:ignore].find_index { |ignore| resource.rsapi_current_state[:name].match(ignore) } } if should[:ignore]
+    rules_resources.delete_if { |resource| should[:ignore].find_index { |ignore| resource.rsapi_current_state[:line].match(ignore) } } if should[:ignore]
 
     # Remove rules that were (presumably) not put in by puppet
     rules_resources.delete_if { |resource| resource.rsapi_current_state[:name].match(%r{^(\d+)[[:graph:][:space:]]})[1].to_i >= 9000 } if should[:ignore_foreign]

lib/puppet/type/firewall.rb

@@ -150,7 +150,7 @@
       type: 'Optional[String[1]]',
       behaviour: :read_only,
       desc: <<-DESC
-      A read only attribute containing the full rule, used when deleting only.
+      A read only attribute containing the full rule, used when deleting and when applying firewallchain purge attributes.
       DESC
     },
     protocol: {