use new facts instead of legacy facts

Author: adrianiurca

lib/puppet/type/firewall.rb

@@ -1850,8 +1850,8 @@ def should_to_s(value)
       MAC Source
     PUPPETCODE
     newvalues(%r{^([0-9a-f]{2}[:]){5}([0-9a-f]{2})$}i)
-    facter_os_name = Facter.value(:operatingsystem).downcase
-    facter_os_release = Facter.value(:operatingsystemrelease).to_i
+    facter_os_name = Facter.value(:os)['name'].downcase
+    facter_os_release = Facter.value(:os)['release']['major'].to_i
     if facter_os_name == 'sles' && facter_os_release == 15
       munge do |value|
         _value = value.downcase