Merge pull request #48 from mhashizume/maint/main/module-updates

Actions and test updates

Author: mhashizume

.github/workflows/jira.yml

@@ -0,0 +1,20 @@
+---
+name: Export issue to Jira
+
+on:
+  issues:
+    types: [labeled]
+
+permissions:
+  issues: write
+
+jobs:
+  export:
+    uses: "puppetlabs/phoenix-github-actions/.github/workflows/jira.yml@main"
+    with:
+      jira-project: PA
+      jira-base-url: ${{ vars.jira_base_url }}
+      jira-user-email: ${{ vars.jira_user_email }}
+    secrets:
+      jira-api-token: ${{ secrets.JIRA_ISSUES_ACTION }}
+

.github/workflows/static_code_analysis.yaml

@@ -6,44 +6,8 @@ on:
     branches: [ main ]
   pull_request:
     branches: [ main ]
+  workflow_dispatch:
 
 jobs:
   static_code_analysis:
-    name: Run checks
-
-    env:
-      ruby_version: 2.6
-      extra_checks: check:symlinks check:git_ignore check:dot_underscore check:test_file
-
-    runs-on: 'ubuntu-20.04'
-    steps:
-      - name: Checkout current PR code
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-
-      - name: Install ruby version ${{ env.ruby_version }}
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ env.ruby_version }}
-
-      - name: Prepare testing environment with bundler
-        run: |
-          git config --global core.longpaths true
-          bundle config set --local without 'release'
-          bundle update --jobs 4 --retry 3
-
-      - name: Run commits check
-        run: bundle exec rake commits
-
-      - name: Run rubocop check
-        run: bundle exec rake ${{ env.extra_checks }} rubocop
-
-      - name: Run syntax check
-        run: bundle exec rake ${{ env.extra_checks }} syntax syntax:hiera syntax:manifests syntax:templates
-
-      - name: Run lint check
-        run: bundle exec rake ${{ env.extra_checks }} lint
-
-      - name: Run metadata_lint check
-        run: bundle exec rake ${{ env.extra_checks }} metadata_lint
+    uses: "puppetlabs/phoenix-github-actions/.github/workflows/static_code_analysis.yaml@main"

metadata.json

@@ -6,7 +6,7 @@
   "license": "Apache-2.0",
   "source": "https://github.com/puppetlabs/puppetlabs-mailalias_core",
   "project_page": "https://github.com/puppetlabs/puppetlabs-mailalias_core",
-  "issues_url": "https://tickets.puppetlabs.com/projects/MODULES",
+  "issues_url": "https://github.com/puppetlabs/puppetlabs-mailalias_core/issues",
   "dependencies": [
 
   ],

rakelib/commits.rake

@@ -34,7 +34,7 @@
 
       # verify the alias is absent
       on(agent, 'cat /etc/aliases') do |res|
-        assert_no_match(%r{#{name}:.*foo,bar,baz}, res.stdout, 'mailalias was not removed from aliases file')
+        refute_match(%r{#{name}:.*foo,bar,baz}, res.stdout, 'mailalias was not removed from aliases file')
       end
     end
   end

spec/acceptance/tests/destroy_spec.rb

@@ -27,8 +27,8 @@
 
   non_windows_agents.each do |agent|
     it 'queries for the mail alias with puppet' do
-      on(agent, puppet_resource('mailalias', name)) do
-        fail_test "didn't find the scheduled_task #{name}" unless stdout.include? 'present'
+      on(agent, puppet_resource('mailalias', name)) do |res|
+        fail_test "didn't find the scheduled_task #{name}" unless res.stdout.include? 'present'
       end
     end
   end