syntax

Author: LukasAud

.github/workflows/integration_test.yml

@@ -300,31 +300,40 @@ jobs:
           ')"
           [[ -n "$ALL" ]] || { echo "No targets found in inventory"; exit 3; }
 
-          if [ -d spec/fixtures/modules/stdlib ]; then
+          if [[ -d spec/fixtures/modules/stdlib ]]; then
             echo "Staging puppetlabs-stdlib to targets..."
-            # Ensure modules root exists and clean out any previous stdlib copy
-            bundle exec bolt command run "/bin/bash -lc '
+
+            # Prepare destination on targets (create modules root, remove any stale stdlib)
+            bundle exec bolt command run '/bin/bash -lc '"'"'
               set -Eeuo pipefail
               MODROOT=/etc/puppetlabs/code/environments/production/modules
-              mkdir -p \"$MODROOT\"
-              rm -rf \"$MODROOT/stdlib\"
-            '" -i spec/fixtures/litmus_inventory.yaml --targets "$ALL" --run-as root
+              mkdir -p "$MODROOT"
+              rm -rf "$MODROOT/stdlib"
+            '"'"' \
+              -i spec/fixtures/litmus_inventory.yaml \
+              --targets "$ALL" \
+              --run-as root
 
-            # Upload the stdlib directory to the modules root (Bolt copies recursively by default)
+            # Upload the stdlib directory to the modules root
             bundle exec bolt file upload spec/fixtures/modules/stdlib \
               /etc/puppetlabs/code/environments/production/modules \
               -i spec/fixtures/litmus_inventory.yaml \
               --targets "$ALL"
 
-            # Lightweight verification
-            bundle exec bolt command run "/bin/bash -lc '
+            # Verify presence
+            bundle exec bolt command run '/bin/bash -lc '"'"'
+              set -Eeuo pipefail
               test -f /etc/puppetlabs/code/environments/production/modules/stdlib/metadata.json \
-                && echo \"stdlib present\" \
-                || (echo \"stdlib missing\" >&2; exit 1)
-            '" -i spec/fixtures/litmus_inventory.yaml --targets "$ALL" --run-as root
+                && echo "stdlib present" \
+                || { echo "stdlib missing" >&2; exit 1; }
+            '"'"' \
+              -i spec/fixtures/litmus_inventory.yaml \
+              --targets "$ALL" \
+              --run-as root
           else
-            echo "WARN: spec/fixtures/modules/stdlib not present."
-            echo "      Ensure .fixtures.yml includes stdlib and that \"bundle exec rake spec_prep\" ran."
+            echo "ERROR: spec/fixtures/modules/stdlib not present."
+            echo "       Ensure .fixtures.yml includes stdlib and that \"bundle exec rake spec_prep\" ran."
+            exit 1
           fi
 
       - name: Verify puppet CLI on all test targets (required)