chore(workflows): remove push trigger from legacy workflows

The push trigger has been removed from the test-legacy-compilers and test-legacy-upgrade workflows. This change ensures that these workflows are only triggered manually via workflow_dispatch.

fix(workflow): correct conditional syntax in test-legacy-upgrade.yaml

- Replace incorrect `AND` with `&&` for accurate conditional checks

Author: CoMfUcIoS

.github/workflows/test-legacy-compilers.yaml

@@ -23,7 +23,6 @@ on:
       - .puppet-lint.rc
       - .fixtures.yml
     branches: [main]
-  push:
   workflow_dispatch:
     inputs:
       ssh-debugging:
@@ -143,8 +142,7 @@ jobs:
           echo ::endgroup::
           echo ::group::smoke_test
           legacy_compiler=$(yq '.items[0].value.params.legacy_compilers[0]' peadm_config.json)
-          if [ "$compiler" != "$legacy_compiler" ]
-          then
+          if [ "$compiler" != "$legacy_compiler" ]; then
             echo "Compiler conversion failed, expected $compiler, got $legacy_compiler"
             exit 1
           fi

.github/workflows/test-legacy-upgrade.yaml

@@ -23,7 +23,6 @@ on:
       - .puppet-lint.rc
       - .fixtures.yml
     branches: [main]
-  push:
   workflow_dispatch:
     inputs:
       ssh-debugging:
@@ -141,7 +140,7 @@ jobs:
           echo ::group::smoke_test
           configured_legacy_compiler=$(yq '.items[0].value.params.legacy_compilers[0]' peadm_config.json)
           configured_compiler=$(yq '.items[0].value.params.compiler_hosts[0]' peadm_config.json)
-          if [ "$configured_legacy_compiler" != "$legacy_compiler" AND "$configured_compiler" != "$compiler" ]
+          if [ "$configured_legacy_compiler" != "$legacy_compiler" ] && [ "$configured_compiler" != "$compiler" ]; then
             echo "Compilers are not configured, expected $legacy_compiler and $compiler, got $configured_legacy_compiler and $configured_compiler"
             exit 1
           fi
@@ -186,7 +185,7 @@ jobs:
           echo ::group::smoke_test
           configured_legacy_compiler=$(yq '.items[0].value.params.legacy_compilers[0]' peadm_config.json)
           configured_compiler=$(yq '.items[0].value.params.compiler_hosts[0]' peadm_config.json)
-          if [ "$configured_legacy_compiler" != "$legacy_compiler" AND "$configured_compiler" != "$compiler" ]
+          if [ "$configured_legacy_compiler" != "$legacy_compiler" ] && [ "$configured_compiler" != "$compiler" ]; then
             echo "Compilers are not configured, expected $legacy_compiler and $compiler, got $configured_legacy_compiler and $configured_compiler"
             exit 1
           fi