tasks: replace os_identification with facts

the facts task is vendored into bolt. It supports gathering facts from
systems with and without facter installed.

Author: bastelfreak

REFERENCE.md

@@ -74,7 +74,6 @@
 * [`infrastatus`](#infrastatus): Runs puppet infra status and returns the output
 * [`mkdir_p_file`](#mkdir_p_file): Create a file with the specified content at the specified location
 * [`mv`](#mv): Wrapper task for mv command
-* [`os_identification`](#os_identification): Return the operating system runnin gon the target as a string
 * [`pe_install`](#pe_install): Install Puppet Enterprise from a tarball
 * [`pe_ldap_config`](#pe_ldap_config): Set the ldap config in the PE console
 * [`pe_uninstall`](#pe_uninstall): Uninstall Puppet Enterprise
@@ -1325,12 +1324,6 @@ Data type: `String`
 
 New path of file
 
-### <a name="os_identification"></a>`os_identification`
-
-Return the operating system runnin gon the target as a string
-
-**Supports noop?** false
-
 ### <a name="pe_install"></a>`pe_install`
 
 Install Puppet Enterprise from a tarball

metadata.json

@@ -35,6 +35,10 @@
     {
       "name": "puppetlabs/ruby_task_helper",
       "version_requirement": ">= 1.0.0 < 2.0.0"
+    },
+    {
+      "name": "puppetlabs/facts",
+      "version_requirement": ">= 1.6.0 < 2.0.0"
     }
   ],
   "operatingsystem_support": [

plans/util/retrieve_and_upload.pp

@@ -29,8 +29,8 @@
     |-HEREDOC
     # lint:endignore
 
-  $operating_system = run_task('peadm::os_identification', 'local://localhost')
-  $os_string =$operating_system.first.value['_output']
+  $operating_system = run_task('facts', 'local://localhost')
+  $os_string =$operating_system.first.value['os']['family']
 
   if 'windows' in $os_string {
     $exists = run_command("[System.IO.File]::Exists('${local_path}')", 'local://localhost')

spec/plans/util/retrieve_and_upload_spec.rb

@@ -5,7 +5,7 @@
   include BoltSpec::Plans
 
   it 'file needs downloaded and needs uploaded' do
-    expect_task('peadm::os_identification')
+    allow_task('facts').be_called_times(1).with_targets('local://localhost').always_return({ 'os' => { 'family' => 'RedHat' } })
     expect_command("test -e '/tmp/download'").error_with('kind' => 'nope', 'msg' => 'The command failed with exit code 1')
     expect_task('peadm::download')
     expect_task('peadm::filesize').be_called_times(2).return_for_targets(