docs: update upgrade_with_legacy_compilers.md with remove_pdb parameter info

- Added information about the `remove_pdb` parameter to the documentation.
- Updated `convert_compiler_to_legacy` plan to set `remove_pdb` default to `true`.

This change provides clarity on how to retain PuppetDB service on converted compilers.

Author: CoMfUcIoS

documentation/upgrade_with_legacy_compilers.md

@@ -40,6 +40,8 @@ bolt plan run peadm::convert_compiler_to_legacy legacy_hosts=compiler1.example.c
 
 The above will create the needed Node group and Classifier rules to make the compilers legacy. Also will add certificate extensions to those nodes.
 
+If you want to keep puppetDB service on the converted compilers, you can do so by passing the `remove_pdb` parameter as `false`.
+
 ### 4. Upgrade Puppet Enterprise
 
 After you have completed the above steps, you can proceed with the upgrade of Puppet Enterprise as usual using the puppetlabs-peadm module. There is no need to do the above ever again.

plans/convert_compiler_to_legacy.pp

@@ -2,7 +2,7 @@
 plan peadm::convert_compiler_to_legacy (
   Peadm::SingleTargetSpec $primary_host,
   TargetSpec $legacy_hosts,
-  Boolean $remove_pdb = false,
+  Boolean $remove_pdb = true,
 ) {
   $primary_target            = peadm::get_targets($primary_host, 1)
   $legacy_compiler_targets             = peadm::get_targets($legacy_hosts)
@@ -39,7 +39,6 @@
       primary_host                     => $primary_target.peadm::certname(),
       internal_compiler_a_pool_address => $cluster['params']['internal_compiler_a_pool_address'],
       internal_compiler_b_pool_address => $cluster['params']['internal_compiler_b_pool_address'],
-      require                          => Class['peadm::setup::node_manager_yaml'],
     }
   }