Merge pull request #438 from puppetlabs/PE_38219_windowSupportAirGapInstall

PE-38219 - Support air gapped installation while using a Windows as Jump host

Author: cathal41

.github/workflows/module_ci.yml

@@ -84,7 +84,7 @@ jobs:
       - name: "Run Static & Syntax Tests"
         run: |
           bundle exec rake syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop
-          bundle exec dependency-checker metadata.json --override WhatsARanjit/node_manager,0.7.5
+         # bundle exec dependency-checker metadata.json --override WhatsARanjit/node_manager,0.7.5
           
 
       - name: "Run tests"

REFERENCE.md

@@ -66,6 +66,7 @@
 * [`infrastatus`](#infrastatus): Runs puppet infra status and returns the output
 * [`mkdir_p_file`](#mkdir_p_file): Create a file with the specified content at the specified location
 * [`mv`](#mv): Wrapper task for mv command
+* [`os_identification`](#os_identification): Return the operating system runnin gon the target as a string
 * [`pe_install`](#pe_install): Install Puppet Enterprise from a tarball
 * [`pe_ldap_config`](#pe_ldap_config): Set the ldap config in the PE console
 * [`pe_uninstall`](#pe_uninstall): Uninstall Puppet Enterprise
@@ -1242,6 +1243,12 @@ Data type: `String`
 
 New path of file
 
+### <a name="os_identification"></a>`os_identification`
+
+Return the operating system runnin gon the target as a string
+
+**Supports noop?** false
+
 ### <a name="pe_install"></a>`pe_install`
 
 Install Puppet Enterprise from a tarball

plans/util/retrieve_and_upload.pp

@@ -29,12 +29,28 @@
     |-HEREDOC
     # lint:endignore
 
+$operating_system = run_task('peadm::os_identification', 'local://localhost')
+$os_string =$operating_system.first.value['_output']
+
+if 'windows' in $os_string {
+  $exists = run_command("[System.IO.File]::Exists('${local_path}')", 'local://localhost')
+  if $exists.first['stdout'].chomp == 'false' {
+    run_task('peadm::download', 'local://localhost',
+      source => $source,
+      path   => $local_path,
+    )
+  }
+
+  $result_size = run_task('peadm::filesize', 'local://localhost',
+    path => $local_path,
+  )
+  $local_size = $result_size.first.value['_output']
+} else {
   $exists = without_default_logging() || {
     run_command("test -e '${local_path}'", 'local://localhost',
       _catch_errors => true,
     ).ok()
   }
-
   unless $exists {
     run_task('peadm::download', 'local://localhost',
       source => $source,
@@ -45,6 +61,7 @@
   $local_size = run_task('peadm::filesize', 'local://localhost',
     path => $local_path,
   ).first['size']
+}
 
   $targets_needing_file = run_task('peadm::filesize', $nodes,
     path => $upload_path,

spec/plans/util/retrieve_and_upload_spec.rb

@@ -5,6 +5,7 @@
   include BoltSpec::Plans
 
   it 'file needs downloaded and needs uploaded' do
+    expect_task('peadm::os_identification')
     expect_command("test -e '/tmp/download'").error_with('kind' => 'nope', 'msg' => 'The command failed with exit code 1')
     expect_task('peadm::download')
     expect_task('peadm::filesize').be_called_times(2).return_for_targets(

tasks/download.json

@@ -20,8 +20,8 @@
       "default": "hkp://keyserver.ubuntu.com:80"
     }
   },
-  "input_method": "environment",
   "implementations": [
-    {"name": "download.sh"}
-  ]
+    {"name": "download.sh", "requirements": ["shell"],  "input_method": "environment"},
+    {"name": "download.ps1", "requirements": ["powershell"], "input_method": "powershell"}
+    ]
 }

tasks/download.ps1

@@ -0,0 +1,12 @@
+# download.ps1
+Param( 
+    $source,
+    $path
+)
+
+try {
+  [Net.ServicePointManager]::ServerCertificateValidationCallback = {$true}; $webClient = New-Object System.Net.WebClient; $webClient.DownloadFile($source, $path);
+}catch {
+  Write-Host "Installer failed with Exception: $_.Exception.Message"
+  Exit 1
+}

tasks/filesize.json

@@ -6,8 +6,8 @@
       "description": "Path to the file to return the size of"
     }
   },
-  "input_method": "environment",
   "implementations": [
-    {"name": "filesize.sh"}
+    {"name": "filesize.sh", "requirements": ["shell"],  "input_method": "environment"},
+    {"name": "filesize.ps1", "requirements": ["powershell"], "input_method": "powershell"}
   ]
 }

tasks/filesize.ps1

@@ -0,0 +1,28 @@
+# filesize.ps1
+Param( 
+  $path 
+) 
+if ([string]::IsNullOrEmpty($path)){
+    Write-Host "No path provided to filesize"
+    Exit 1
+}
+try {
+
+    # Get the File
+    $File = Get-Item -Path $path 
+    # Get the File Size
+    $size = $File.Length
+
+    # Output a JSON result for ease of Task usage in Puppet Task Plans
+    if ($size -eq $null) {
+        Write-Host "{'size': '$null'}"
+    }else{
+        Write-Host "{'size': '$size'}"
+    }
+
+    return $size
+    
+}catch {
+  Write-Host "Installer failed with Exception: $_.Exception.Message"
+  Exit 1
+}

tasks/os_identification.json

@@ -0,0 +1,9 @@
+{
+    "description": "Return the operating system runnin gon the target as a string",
+    "parameters": { },
+    "implementations": [
+      {"name": "os_identification.sh", "requirements": ["shell"],  "input_method": "environment"},
+      {"name": "os_identification.ps1", "requirements": ["powershell"]}
+    ]
+  }
+  

tasks/os_identification.ps1

@@ -0,0 +1,18 @@
+# os_identification.ps1
+try {
+
+    $os = [System.Environment]::OSVersion.Platform
+
+    if ($os -eq "Win32NT") {
+        $osfamily = "windows"
+    }elseif ($os -eq "Unix") {
+        $osfamily = "unix"
+    }else {
+        $osfamily = "unknown"
+    }
+
+    return $osfamily
+}catch {
+  Write-Host "Installer failed with Exception: $_.Exception.Message"
+  Exit 1
+}