Skip to content

Commit 8bb404f

Browse files
committed
fix(workflow): correct bolt task target flag and improve error message
- Changed `-t` to `--targets` for the `bolt task run` command to ensure proper target specification. - Enhanced the error message for compiler conversion failure to include expected and actual values.
1 parent d0f3642 commit 8bb404f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/test-upgrade-legacy.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,16 +133,17 @@ jobs:
133133
primary=$(yq '.groups[].targets[] | select(.vars.role == "primary") | .name' spec/fixtures/litmus_inventory.yaml)
134134
compiler=$(yq '.groups[].targets[] | select(.vars.role == "compiler") | .name' spec/fixtures/litmus_inventory.yaml | head -n 1)
135135
bundle exec bolt task run peadm::get_peadm_config \
136-
-t $primary \
136+
--targets $primary \
137137
--modulepath spec/fixtures/modules \
138138
--no-host-key-check \
139139
--format json > peadm_config.json
140140
cat peadm_config.json
141141
echo ::endgroup::
142142
echo ::group::smoke_test
143143
legacy_compiler=$(yq '.items[0].value.params.legacy_compilers[0]' peadm_config.json)
144-
if [ "$compiler" != "$legacy_compiler" ]; then
145-
echo "Compiler conversion failed"
144+
if [ "$compiler" != "$legacy_compiler" ]
145+
then
146+
echo "Compiler conversion failed, expected $compiler, got $legacy_compiler"
146147
exit 1
147148
fi
148149
echo ::endgroup::

0 commit comments

Comments
 (0)