(PE-38653) Moving workflows install password to secrets (#481)

ragingra · Neil Anderson · web-flow · commit ab9db394315b · 2024-08-28T13:24:41.000+01:00
Co-authored-by: Neil Anderson &lt;neil.anderson@perforce.com&gt;
diff --git a/.github/workflows/test-add-compiler.yaml b/.github/workflows/test-add-compiler.yaml
@@ -97,7 +97,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: 'Run add_compiler plan'
         timeout-minutes: 30
diff --git a/.github/workflows/test-add-replica.yaml b/.github/workflows/test-add-replica.yaml
@@ -97,7 +97,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: 'Run add_replica plan'
         timeout-minutes: 30
diff --git a/.github/workflows/test-backup-restore-migration.yaml b/.github/workflows/test-backup-restore-migration.yaml
@@ -94,7 +94,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ inputs.architecture }} \
-            version=${{ inputs.version }}
+            version=${{ inputs.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Start SSH session"
         if: github.event.inputs.ssh-debugging == 'true'
@@ -216,7 +217,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ inputs.architecture }} \
-            version=${{ inputs.version }}
+            version=${{ inputs.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: Wait for backup to finish
         uses: lewagon/wait-on-check-action@v1.3.4
diff --git a/.github/workflows/test-backup-restore.yaml b/.github/workflows/test-backup-restore.yaml
@@ -100,6 +100,7 @@ jobs:
             --modulepath spec/fixtures/modules \
             architecture=${{ github.event.inputs.architecture || 'extra-large' }} \
             version=${{ github.event.inputs.version || '2023.5.0' }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }} \
             --stream
 
       - name: Perform peadm backup of cluster
diff --git a/.github/workflows/test-failover.yaml b/.github/workflows/test-failover.yaml
@@ -100,7 +100,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: 'Perform failover'
         run: |
diff --git a/.github/workflows/test-fips-install-matrix.yaml b/.github/workflows/test-fips-install-matrix.yaml
@@ -102,7 +102,8 @@ jobs:
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
             version=${{ matrix.version }} \
-            fips=${{ matrix.fips }}
+            fips=${{ matrix.fips }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Tear down test cluster"
         if: ${{ always() }}
diff --git a/.github/workflows/test-install-latest-dev.yaml b/.github/workflows/test-install-latest-dev.yaml
@@ -111,7 +111,8 @@ jobs:
             permit_unsafe_versions=true \
             download_mode="bolthost" \
             architecture=${{ matrix.architecture }} \
-            pe_installer_source="https://artifactory.delivery.puppetlabs.net/artifactory/generic_enterprise__local/main/ci-ready/puppet-enterprise-${{ steps.latest.outputs.ver }}-el-8-x86_64.tar"
+            pe_installer_source="https://artifactory.delivery.puppetlabs.net/artifactory/generic_enterprise__local/main/ci-ready/puppet-enterprise-${{ steps.latest.outputs.ver }}-el-8-x86_64.tar" \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Wait as long as the file ${HOME}/pause file is present"
         if: ${{ always() && github.event.inputs.ssh-debugging == 'true' }}
diff --git a/.github/workflows/test-install-latest-xlarge-dev-nightly.yaml b/.github/workflows/test-install-latest-xlarge-dev-nightly.yaml
@@ -97,7 +97,8 @@ jobs:
             permit_unsafe_versions=true \
             download_mode="bolthost" \
             architecture=${{ matrix.architecture }} \
-            pe_installer_source="https://artifactory.delivery.puppetlabs.net/artifactory/generic_enterprise__local/main/ci-ready/puppet-enterprise-${{ steps.latest.outputs.ver }}-el-8-x86_64.tar"
+            pe_installer_source="https://artifactory.delivery.puppetlabs.net/artifactory/generic_enterprise__local/main/ci-ready/puppet-enterprise-${{ steps.latest.outputs.ver }}-el-8-x86_64.tar" \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Wait as long as the file ${HOME}/pause file is present"
         if: ${{ always() && github.event.inputs.ssh-debugging == 'true' }}
diff --git a/.github/workflows/test-install-matrix.yaml b/.github/workflows/test-install-matrix.yaml
@@ -99,7 +99,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Tear down test cluster"
         if: ${{ always() }}
diff --git a/.github/workflows/test-install-rhel-9.yaml b/.github/workflows/test-install-rhel-9.yaml
@@ -98,7 +98,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Tear down test cluster"
         if: ${{ always() }}
diff --git a/.github/workflows/test-install.yaml b/.github/workflows/test-install.yaml
@@ -97,7 +97,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: 'Wait as long as the file ${HOME}/pause file is present'
         if: ${{ always() && github.event.inputs.ssh-debugging == 'true' }}
diff --git a/.github/workflows/test-upgrade-latest-dev.yaml b/.github/workflows/test-upgrade-latest-dev.yaml
@@ -106,7 +106,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Wait as long as the file ${HOME}/pause file is present"
         if: ${{ always() && github.event.inputs.ssh-debugging == 'true' }}
diff --git a/.github/workflows/test-upgrade-latest-xlarge-dev-nightly.yaml b/.github/workflows/test-upgrade-latest-xlarge-dev-nightly.yaml
@@ -74,7 +74,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: "Activate twingate to obtain unreleased build"
         uses: twingate/github-action@main
diff --git a/.github/workflows/test-upgrade-matrix.yaml b/.github/workflows/test-upgrade-matrix.yaml
@@ -115,7 +115,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: 'Wait as long as the file ${HOME}/pause file is present'
         if: ${{ always() && github.event.inputs.ssh-debugging == 'true' }}
diff --git a/.github/workflows/test-upgrade.yaml b/.github/workflows/test-upgrade.yaml
@@ -113,7 +113,8 @@ jobs:
             --inventoryfile spec/fixtures/litmus_inventory.yaml \
             --modulepath spec/fixtures/modules \
             architecture=${{ matrix.architecture }} \
-            version=${{ matrix.version }}
+            version=${{ matrix.version }} \
+            console_password=${{ secrets.CONSOLE_PASSWORD }}
 
       - name: 'Wait as long as the file ${HOME}/pause file is present'
         if: ${{ always() && github.event.inputs.ssh-debugging == 'true' }}
diff --git a/spec/acceptance/peadm_spec/plans/install_test_cluster.pp b/spec/acceptance/peadm_spec/plans/install_test_cluster.pp
@@ -5,7 +5,9 @@
   Optional[String[1]]       $version                = undef,
   Optional[String[1]]       $pe_installer_source    = undef,
   Boolean                   $permit_unsafe_versions = false,
-  Enum['enable', 'disable'] $fips                   = 'disable'
+  Enum['enable', 'disable'] $fips                   = 'disable',
+  String[1]                 $console_password
+
 ) {
   $t = get_targets('*')
   wait_until_available($t)
@@ -25,7 +27,7 @@
   }
 
   $common_params = {
-    console_password       => 'puppetLabs123!',
+    console_password       => $console_password,
     download_mode          => $download_mode,
     code_manager_auto_configure => $code_manager_auto_configure,
     version                => $version,
