Move download_type enum to own type alias (#525)

This allows users of PEADM to reuse the type and validate their input properly before calling peadm.

Author: bastelfreak

REFERENCE.md

@@ -44,6 +44,7 @@
 ### Data types
 
 * [`Peadm::ConvertSteps`](#Peadm--ConvertSteps): type for the different steps where the peadm::convert plan can be started
+* [`Peadm::Download_mode`](#Peadm--Download_mode): download the installer to the bolt node and upload to targets, or let the targets download it directly
 * [`Peadm::Known_hosts`](#Peadm--Known_hosts)
 * [`Peadm::Ldap_config`](#Peadm--Ldap_config)
 * [`Peadm::Pe_version`](#Peadm--Pe_version)
@@ -928,6 +929,12 @@ type for the different steps where the peadm::convert plan can be started
 
 Alias of `Enum['modify-primary-certs', 'modify-infra-certs', 'convert-node-groups', 'finalize']`
 
+### <a name="Peadm--Download_mode"></a>`Peadm::Download_mode`
+
+download the installer to the bolt node and upload to targets, or let the targets download it directly
+
+Alias of `Enum['direct', 'bolthost']`
+
 ### <a name="Peadm--Known_hosts"></a>`Peadm::Known_hosts`
 
 The Peadm::Known_hosts data type.
@@ -2262,7 +2269,7 @@ Default value: `undef`
 
 ##### <a name="-peadm--install--download_mode"></a>`download_mode`
 
-Data type: `Enum['direct', 'bolthost']`
+Data type: `Peadm::Download_mode`
 
 
 
@@ -2654,7 +2661,7 @@ Default value: `undef`
 
 ##### <a name="-peadm--upgrade--download_mode"></a>`download_mode`
 
-Data type: `Enum[direct,bolthost]`
+Data type: `Peadm::Download_mode`
 
 
 

plans/install.pp

@@ -71,7 +71,7 @@
   Optional[String]           $stagingdir             = undef,
   Optional[String]           $uploaddir              = undef,
   Enum['running', 'stopped'] $final_agent_state      = 'running',
-  Enum['direct', 'bolthost'] $download_mode          = 'bolthost',
+  Peadm::Download_mode       $download_mode          = 'bolthost',
   Boolean                    $permit_unsafe_versions = false,
   String                     $token_lifetime         = '1y',
 ) {

plans/subplans/install.pp

@@ -68,7 +68,7 @@
   # Other
   String                $stagingdir             = '/tmp',
   String                $uploaddir              = '/tmp',
-  Enum[direct,bolthost] $download_mode          = 'bolthost',
+  Peadm::Download_mode  $download_mode          = 'bolthost',
   Boolean               $permit_unsafe_versions = false,
   String                $token_lifetime         = '1y',
 ) {

plans/upgrade.pp

@@ -57,7 +57,7 @@
   String                     $stagingdir             = '/tmp',
   String                     $uploaddir              = '/tmp',
   Enum['running', 'stopped'] $final_agent_state      = 'running',
-  Enum[direct,bolthost]      $download_mode          = 'bolthost',
+  Peadm::Download_mode       $download_mode          = 'bolthost',
   Boolean                    $permit_unsafe_versions = false,
 
   Optional[Peadm::UpgradeSteps] $begin_at_step = undef,

types/download_mode.pp

@@ -0,0 +1,2 @@
+# @summary download the installer to the bolt node and upload to targets, or let the targets download it directly
+type Peadm::Download_mode = Enum['direct','bolthost']