Use service provider to determine service commands

Rather than using static OS definitions, this uses the service_provider
parameter or fact (provided by puppetlabs/stdlib).

Author: ekohl

manifests/params.pp

@@ -82,28 +82,12 @@
         $postgresql_conf_mode   = pick($postgresql_conf_mode, '0600')
       }
 
-      case $facts['os']['name'] {
-        'Amazon': {
-          $service_reload = "service ${service_name} reload"
-          $service_status = "service ${service_name} status"
-        }
-
-        # RHEL 5 uses SysV init, RHEL 6 uses upstart, RHEL 7+ uses systemd.
-        'RedHat', 'CentOS', 'Scientific', 'OracleLinux': {
-          if versioncmp($facts['os']['release']['major'], '7') >= 0 {
-            $service_reload = "systemctl reload ${service_name}"
-            $service_status = "systemctl status ${service_name}"
-          } else {
-            $service_reload = "service ${service_name} reload"
-            $service_status = "service ${service_name} status"
-          }
-        }
-
-        # Default will catch Fedora which uses systemd
-        default: {
-          $service_reload = "systemctl reload ${service_name}"
-          $service_status = "systemctl status ${service_name}"
-        }
+      if pick($service_provider, $facts['service_provider']) == 'systemd' {
+        $service_reload = "systemctl reload ${service_name}"
+        $service_status = "systemctl status ${service_name}"
+      } else {
+        $service_reload = "service ${service_name} reload"
+        $service_status = "service ${service_name} status"
       }
 
       $psql_path           = pick($psql_path, "${bindir}/psql")