Fix strftime() deprecation warning

smortex · smortex · commit 0c284b91a46c · 2024-04-11T14:43:45.000-10:00
When running on Puppet 8, a warning is produced:
```
The argument signature (String format, [String timezone]) is deprecated for #strftime. See #strftime documentation and Timespan type for more info
```

Pass a timestamp as the first parameter to use a non-deprecated
signature of the function `(Timespan $time_object, String $format)`.
diff --git a/manifests/install/windows.pp b/manifests/install/windows.pp
@@ -57,7 +57,7 @@
     $_puppet_run_wait = undef
   }
 
-  $_timestamp = strftime('%Y_%m_%d-%H_%M')
+  $_timestamp = Timestamp().strftime('%Y_%m_%d-%H_%M')
   $_logfile = windows_native_path("${facts['env_temp_variable']}/puppet-${_timestamp}-installer.log")
 
   notice ("Puppet upgrade log file at ${_logfile}")

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@`
`57`	`57`	`$_puppet_run_wait = undef`
`58`	`58`	`}`
`59`	`59`
`60`		`- $_timestamp = strftime('%Y_%m_%d-%H_%M')`
	`60`	`+ $_timestamp = Timestamp().strftime('%Y_%m_%d-%H_%M')`
`61`	`61`	`$_logfile = windows_native_path("${facts['env_temp_variable']}/puppet-${_timestamp}-installer.log")`
`62`	`62`
`63`	`63`	`notice ("Puppet upgrade log file at ${_logfile}")`