(maint) puppet-lint file_ensure check

Author: AriaXLi

manifests/osfamily/debian.pp

@@ -83,7 +83,7 @@
       }
 
       file { $legacy_gpg_path:
-        ensure => present,
+        ensure => file,
         owner  => 0,
         group  => 0,
         mode   => '0644',
@@ -96,7 +96,7 @@
       }
 
       file { $gpg_path:
-        ensure => present,
+        ensure => file,
         owner  => 0,
         group  => 0,
         mode   => '0644',

manifests/osfamily/redhat.pp

@@ -104,23 +104,24 @@
   rpm --import "${GPG_KEY_PATH}"
 fi
 | SCRIPT
+# lint:endignore
 
-    if $::puppet_agent::manage_pki_dir == true {
+    if $puppet_agent::manage_pki_dir == true {
       file { ['/etc/pki', '/etc/pki/rpm-gpg']:
         ensure => directory,
       }
     }
 
     file { $legacy_gpg_path:
-      ensure => present,
+      ensure => file,
       owner  => 0,
       group  => 0,
       mode   => '0644',
       source => "puppet:///modules/puppet_agent/${legacy_keyname}",
     }
 
     file { $gpg_path:
-      ensure => present,
+      ensure => file,
       owner  => 0,
       group  => 0,
       mode   => '0644',

manifests/osfamily/solaris.pp

@@ -49,7 +49,7 @@
       }
 
       file { '/opt/puppetlabs/packages/solaris-noask':
-        ensure => present,
+        ensure => file,
         owner  => 0,
         group  => 0,
         mode   => '0644',

manifests/osfamily/suse.pp

@@ -93,15 +93,15 @@
         }
 
         file { $gpg_path:
-          ensure => present,
+          ensure => file,
           owner  => 0,
           group  => 0,
           mode   => '0644',
           source => "puppet:///modules/puppet_agent/${keyname}",
         }
 
         file { $legacy_gpg_path:
-          ensure => present,
+          ensure => file,
           owner  => 0,
           group  => 0,
           mode   => '0644',

manifests/prepare/package.pp

@@ -27,9 +27,9 @@
   }
 
   file { $local_package_file_path:
-    ensure   => present,
-    owner    => $::puppet_agent::params::user,
-    group    => $::puppet_agent::params::group,
+    ensure   => file,
+    owner    => $puppet_agent::params::user,
+    group    => $puppet_agent::params::group,
     mode     => $mode,
     source   => $source,
     require  => File[$puppet_agent::params::local_packages_dir],