(MODULES-11123) Avoid loading puppet facts in install/windows.pp

The install puppet command in `manifests/install/windows.pp` is executed
if the desired version is not already installed. This is done by asking
facter the value of the `aio_agent_version` fact on the target node and
is compared to expected package version.

Before this commit, facter was asked to also load puppet facts (using
the `-p` parameter) which was causing high load times due to unnecessary
facts getting loaded and resolved when currently installed puppet agent
version was the only information needed.

This fix removes the puppet facts loading for this command requirement
and lowers catalog application time by as much as half in some
scenarios.

Author: luchihoratiu

manifests/install/windows.pp

@@ -109,7 +109,7 @@
                   -NoProfile \
                   -NoLogo \
                   -NonInteractive \
-                  -Command {\$CurrentVersion = [string](facter.bat -p aio_agent_version); \
+                  -Command {\$CurrentVersion = [string](facter.bat aio_agent_version); \
                             if (\$CurrentVersion -eq '${::puppet_agent::_expected_package_version}') { \
                               exit 0; \
                             } \

spec/classes/puppet_agent_windows_install_spec.rb

@@ -82,7 +82,7 @@
             {:package_version => '5.6.7'})
           }
           it {
-            is_expected.to contain_exec('install_puppet.ps1').with_unless(/\-Command {\$CurrentVersion = \[string\]\(facter.bat \-p aio_agent_version\);/)
+            is_expected.to contain_exec('install_puppet.ps1').with_unless(/\-Command {\$CurrentVersion = \[string\]\(facter.bat aio_agent_version\);/)
             is_expected.to contain_exec('install_puppet.ps1').with_unless(/\-Command.*if \(\$CurrentVersion \-eq '5\.6\.7'\) { +exit 0; *} *exit 1; }\.Invoke\(\)/)
           }
         end