Add support for development MSI builds

Dev builds have more than 3 dotted components

Author: joshcooper

manifests/prepare/package.pp

@@ -35,6 +35,7 @@
   if $puppet_agent::collection =~ /core/ and $facts['os']['family'] =~ /windows/ {
     $download_username = getvar('puppet_agent::username', 'forge-key')
     $download_password = unwrap(getvar('puppet_agent::password'))
+    $dev = count(split($puppet_agent::prepare::package_version, '\.')) > 3
 
     $_download_puppet = windows_native_path("${facts['env_temp_variable']}/download_puppet.ps1")
     file { $_download_puppet:

tasks/install_powershell.ps1

@@ -124,9 +124,14 @@ if (($collection -like '*nightly*') -And -Not ($PSBoundParameters.ContainsKey('w
 
 if ($absolute_source) {
     $msi_source = "$absolute_source"
-}
-elseif ($collection -like '*puppetcore*') {
-    $msi_source = "${windows_source}?version=${version}&os_name=windows&os_version=${major_os_version}&os_arch=${arch}&fips=${fips}"
+} elseif ($collection -like '*puppetcore*') {
+    # dev param is case-sensitive, so don't use $True
+    if (($version -split '\.').count -gt 3) {
+        $dev = '&dev=true'
+    } else {
+        $dev = ''
+    }
+    $msi_source = "${windows_source}?version=${version}&os_name=windows&os_version=${major_os_version}&os_arch=${arch}&fips=${fips}${dev}"
 } else {
     $msi_source = "$windows_source/windows/${collection}/${msi_name}"
 }

templates/download_puppet.ps1.epp

@@ -1,9 +1,10 @@
 $body = @{
-    "version" = "<%= $puppet_agent::prepare::package_version %>"
-    "os_name" = "<%= $facts['os']['family'] %>"
+    "version"    = "<%= $puppet_agent::prepare::package_version %>"
+    "dev"        = "<%= $puppet_agent::prepare::package::dev %>"
+    "os_name"    = "<%= $facts['os']['family'] %>"
     "os_version" = "<%= $facts['os']['release']['major'] %>"
-    "os_arch" = "<%= $facts['os']['architecture'] %>"
-    "fips" = "<%= $facts['fips_enabled'] %>"
+    "os_arch"    = "<%= $facts['os']['architecture'] %>"
+    "fips"       = "<%= $facts['fips_enabled'] %>"
 }
 $username = "<%= $puppet_agent::prepare::package::download_username %>"
 $password = ConvertTo-SecureString "<%= $puppet_agent::prepare::package::download_password %>" -AsPlainText -Force