(maint) Delete duplicate tests

This code was last updated in Oct 2020 and all this time we've been testing
"upgrades" from 7.x to 5.5.21. This only recently started to fail when stdlib v9
was released as the root_home fact uses Ruby syntax that's not valid in Puppet
5/Ruby 2.1.9.

It's not practical to update the upgrade tests after each release. And we already test
upgrades and idempotency in the acceptance/tests/*, so delete these tests.

Author: joshcooper

spec/acceptance/class_spec.rb

@@ -6,22 +6,6 @@
     before(:all) { setup_puppet_on default }
     after(:all) { teardown_puppet_on default }
 
-    it 'works idempotently with no errors' do
-      pp = <<-EOS
-      class { 'puppet_agent': package_version => '5.5.21', collection => 'puppet5' }
-      EOS
-
-      apply_manifest(pp, catch_failures: true)
-      wait_for_finish_on default
-      configure_agent_on default
-      # Run three times to ensure idempotency if upgrading with the package resource (MODULES-10666)
-      unless %r{solaris-10|aix|osx|windows}i.match?(default['platform'])
-        apply_manifest(pp, expect_changes: true)
-        wait_for_finish_on default
-      end
-      apply_manifest(pp, catch_changes: true)
-    end
-
     describe package(package_name(default)) do
       it { is_expected.to be_installed }
     end
@@ -117,43 +101,4 @@ class { 'puppet_agent': service_names => [] }
       it { is_expected.not_to be_running }
     end
   end
-
-  unless %r{windows}i.match?(default['platform'])
-    unless %r{solaris-10|aix|osx|windows}i.match?(default['platform'])
-      context 'on platforms managed with the package resource' do
-        before(:all) { setup_puppet_on default }
-
-        after(:all) do
-          on default, 'rm -f /tmp/a'
-          teardown_puppet_on default
-        end
-
-        let(:manifest) do
-          <<-EOS
-      class { 'puppet_agent': package_version => '5.5.21', collection => 'puppet5', before => File['/tmp/a'] }
-      file { '/tmp/a': ensure => 'present' }
-      EOS
-        end
-
-        it 'upgrades the agent on the first run' do
-          # First run should upgrade the agent
-          apply_manifest(manifest, expect_changes: true)
-          configure_agent_on default
-          expect(package(package_name(default))).to be_installed
-          expect(file('/tmp/a')).not_to exist
-        end
-
-        it 'evaluates remanining resources on the second run' do
-          # Second run should apply the file resource
-          apply_manifest(manifest, expect_changes: true)
-          expect(file('/tmp/a')).to exist
-        end
-
-        it 'does nothing on future runs' do
-          # Third run should not do anything
-          apply_manifest(manifest, catch_changes: true)
-        end
-      end
-    end
-  end
 end