Drop ssl_verify=no on SLES

Originally SLES 12 was a PE-only agent installed from the PE server, which
creates a self-signed CA, so commit 1b62f86
disabled SSL verification.

Later commit 6b7fda9 extended the module for
open source SLES, and we continued to disable ssl verification.

Later commit 8256a2c added a guard clause

    unless $::operatingsystemmajrelease == '11' and $::puppet_agent::is_pe {
      if getvar('::puppet_agent::manage_repo') == true {

which meant we only disabled ssl verification on not-PE.

There's no good reason to continue doing that, so remove it.

Author: joshcooper

manifests/osfamily/suse.pp

@@ -134,9 +134,6 @@
             # 'auto' versus X.Y.Z
             $_package_version = getvar('puppet_agent::master_or_package_version')
 
-            # In Puppet Enterprise, agent packages are served by the same server
-            # as the master, which can be using either a self signed CA, or an external CA.
-            # Zypper has issues with validating a self signed CA, so for now disable ssl verification.
             # don't leak credentials
             $repo_username = getvar('puppet_agent::username')
             $repo_password = unwrap(getvar('puppet_agent::password'))
@@ -158,7 +155,7 @@
               'enabled'     => '1',
               'gpgcheck'    => '1',
               'autorefresh' => '0',
-              'baseurl'     => "${source}?ssl_verify=no&auth=basic&credentials=PuppetcoreCreds",
+              'baseurl'     => "${source}?auth=basic&credentials=PuppetcoreCreds",
               'type'        => 'rpm-md',
             }
 

spec/classes/puppet_agent_osfamily_suse_spec.rb

@@ -151,7 +151,7 @@
                   'enabled'     => '1',
                   'gpgcheck'    => '1',
                   'autorefresh' => '0',
-                  'baseurl'     => "https://yum-puppetcore.puppet.com/puppet6/sles/#{os_version}/x86_64?ssl_verify=no&auth=basic&credentials=PuppetcoreCreds",
+                  'baseurl'     => "https://yum-puppetcore.puppet.com/puppet6/sles/#{os_version}/x86_64?auth=basic&credentials=PuppetcoreCreds",
                   'type'        => 'rpm-md',
                 }.each do |setting, value|
                   it {
@@ -203,7 +203,7 @@
                             'path' => '/etc/zypp/repos.d/pc_repo.repo',
                             'section' => 'pc_repo',
                             'setting' => 'baseurl',
-                            'value'   => "https://nightlies.puppet.com/yum/puppet6/sles/#{os_version}/x86_64?ssl_verify=no&auth=basic&credentials=PuppetcoreCreds",
+                            'value'   => "https://nightlies.puppet.com/yum/puppet6/sles/#{os_version}/x86_64?auth=basic&credentials=PuppetcoreCreds",
                           })
                 }
               end
@@ -291,7 +291,7 @@
                   'enabled'     => '1',
                   'gpgcheck'    => '1',
                   'autorefresh' => '0',
-                  'baseurl'     => "https://master.example.vm:8140/packages/2000.0.0/sles-#{os_version}-x86_64?ssl_verify=no&auth=basic&credentials=PuppetcoreCreds",
+                  'baseurl'     => "https://master.example.vm:8140/packages/2000.0.0/sles-#{os_version}-x86_64?auth=basic&credentials=PuppetcoreCreds",
                   'type'        => 'rpm-md',
                 }.each do |setting, value|
                   it {
@@ -341,7 +341,7 @@
                             'path'    => '/etc/zypp/repos.d/pc_repo.repo',
                             'section' => 'pc_repo',
                             'setting' => 'baseurl',
-                            'value'   => "https://fake-sles-source.com/packages/2000.0.0/sles-#{os_version}-x86_64?ssl_verify=no&auth=basic&credentials=PuppetcoreCreds",
+                            'value'   => "https://fake-sles-source.com/packages/2000.0.0/sles-#{os_version}-x86_64?auth=basic&credentials=PuppetcoreCreds",
                           })
                 }
               end