Checkout the latest tagged module version

Checkout the latest tagged module version when installing the agent.
This has to be done separately for dnf & sles. We can't use `puppet
module install` in the install task, because puppet hasn't been
installed yet.

As a result of this change, we have to clone the entire repo, rather
than using depth=1, since there's no guarantee that the latest commit
will be tagged.

Also update the commented out git clone commands in the upgrade scripts.
Those can be useful if you need to test that an unreleased change in a
module dependency won't break this module.

Author: joshcooper

docker/install/dnf/Dockerfile

@@ -33,10 +33,14 @@ COPY metadata.json ./
 
 # Installing dependencies from source. These versions should be within the range
 # of `dependencies` in metadata.json.
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib --branch v9.7.0
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-inifile ../inifile --branch v6.2.0
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-apt ../apt --branch v10.0.1
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-facts ../facts --branch 1.7.0
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib && \
+    $(cd ../stdlib && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-inifile ../inifile && \
+    $(cd ../inifile && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-apt ../apt && \
+    $(cd ../apt && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-facts ../facts && \
+    $(cd ../facts && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
 
 # Now move the project directory's files into the image. That way, if these
 # files change, caching will skip everything before this.

docker/install/sles/Dockerfile

@@ -27,10 +27,14 @@ COPY metadata.json ./
 
 # Installing dependencies from source. These versions should be within the range
 # of `dependencies` in metadata.json.
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib --branch v9.7.0
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-inifile ../inifile --branch v6.2.0
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-apt ../apt --branch v10.0.1
-RUN git clone --depth 1 https://github.com/puppetlabs/puppetlabs-facts ../facts --branch 1.7.0
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib && \
+    $(cd ../stdlib && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-inifile ../inifile && \
+    $(cd ../inifile && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-apt ../apt && \
+    $(cd ../apt && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+RUN git clone --tags https://github.com/puppetlabs/puppetlabs-facts ../facts && \
+    $(cd ../facts && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
 
 # Now move the project directory's files into the image. That way, if these
 # files change, caching will skip everything before this.

docker/upgrade/dnf/Dockerfile

@@ -70,10 +70,14 @@ RUN /opt/puppetlabs/puppet/bin/puppet module install --modulepath $module_path -
 
 # Installing dependencies from source. These versions should be within the range
 # of `dependencies` in metadata.json.
-#RUN git clone https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib --branch 9.7.0
-#RUN git clone https://github.com/puppetlabs/puppetlabs-inifile ../inifile --branch 6.2.0
-#RUN git clone https://github.com/puppetlabs/puppetlabs-apt ../apt --branch 10.0.1
-#RUN git clone https://github.com/puppetlabs/puppetlabs-facts ../facts --branch 1.7.0
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib && \
+#     $(cd ../stdlib && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-inifile ../inifile && \
+#     $(cd ../inifile && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-apt ../apt && \
+#     $(cd ../apt && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-facts ../facts && \
+#     $(cd ../facts && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
 
 # Check that all dependencies are installed.
 RUN /opt/puppetlabs/puppet/bin/puppet module --modulepath $module_path list --tree

docker/upgrade/sles/Dockerfile

@@ -64,10 +64,14 @@ RUN /opt/puppetlabs/puppet/bin/puppet module install --modulepath $module_path -
 
 # Installing dependencies from source. These versions should be within the range
 # of `dependencies` in metadata.json.
-#RUN git clone https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib --branch 9.7.0
-#RUN git clone https://github.com/puppetlabs/puppetlabs-inifile ../inifile --branch 6.2.0
-#RUN git clone https://github.com/puppetlabs/puppetlabs-apt ../apt --branch 10.0.1
-#RUN git clone https://github.com/puppetlabs/puppetlabs-facts ../facts --branch 1.7.0
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-stdlib ../stdlib && \
+#     $(cd ../stdlib && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-inifile ../inifile && \
+#     $(cd ../inifile && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-apt ../apt && \
+#     $(cd ../apt && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
+# RUN git clone --tags https://github.com/puppetlabs/puppetlabs-facts ../facts && \
+#     $(cd ../facts && git checkout $(git describe --tags $(git rev-list --tags --max-count=1)))
 
 # Check that all dependencies are installed.
 RUN /opt/puppetlabs/puppet/bin/puppet module --modulepath $module_path list --tree