Download puppet8 packages from yum-puppetcore.puppet.com

Add optional `username` and `password` class parameters to init.pp

Change default `yum_source` parameter from http://yum.puppet.com to
https://yum-support.puppet.com. Note the change to HTTPS.

Author: joshcooper

manifests/init.pp

@@ -34,8 +34,8 @@
 #   The exact location of the package to install. The entire path to the package must be
 #   provided with this parameter.
 # @param yum_source
-#   Base URL of the location of mirrors of yum.puppet.com downloads sites. Directories under
-#   the URL "yum_source" should match the structure of the yum.puppet.com
+#   Base URL of the location of mirrors of yum-puppetcore.puppet.com downloads sites. Directories under
+#   the URL "yum_source" should match the structure of the yum-puppetcore.puppet.com
 # @param apt_source
 #   Base URL of the location of mirrors of apt.puppet.com downloads sites. Directories under
 #   the URL "apt_source" should match the structure of the apt.puppet.com
@@ -114,7 +114,7 @@
   Array                          $service_names           = $puppet_agent::params::service_names,
   Optional                       $source                  = undef,
   Optional                       $absolute_source         = undef,
-  String                         $yum_source              = 'http://yum.puppet.com',
+  String                         $yum_source              = 'https://yum-puppetcore.puppet.com',
   String                         $apt_source              = 'https://apt.puppet.com',
   String                         $mac_source              = 'https://downloads.puppet.com',
   String                         $windows_source          = 'https://downloads.puppet.com',
@@ -131,7 +131,9 @@
   Optional                       $wait_for_pxp_agent_exit = undef,
   Optional                       $wait_for_puppet_run     = undef,
   Array[Puppet_agent::Config]    $config                  = [],
-  Stdlib::Absolutepath           $version_file_path       = '/opt/puppetlabs/puppet/VERSION'
+  Stdlib::Absolutepath           $version_file_path       = '/opt/puppetlabs/puppet/VERSION',
+  Optional                       $username                = undef,
+  Optional[Sensitive]            $password                = undef,
 ) inherits puppet_agent::params {
   # The configure class uses $puppet_agent::config to manage settings in
   # puppet.conf, and will always be present. It does not require management of

manifests/osfamily/redhat.pp

@@ -175,6 +175,8 @@
         sslclientcert       => $_sslclientcert_path,
         sslclientkey        => $_sslclientkey_path,
         skip_if_unavailable => $puppet_agent::skip_if_unavailable,
+        username            => $puppet_agent::username,
+        password            => $puppet_agent::password,
       }
     }
   }

spec/classes/puppet_agent_osfamily_redhat_spec.rb

@@ -151,7 +151,7 @@
           is_expected.to contain_yumrepo('pc_repo')
             .with({
                     # We no longer expect the 'f' in fedora repos
-                    'baseurl'  => "http://yum.puppet.com/puppet5/#{urlbit.gsub('/f', '/')}/#{arch}",
+                    'baseurl'  => "https://yum-puppetcore.puppet.com/puppet5/#{urlbit.gsub('/f', '/')}/#{arch}",
                     'enabled'  => 'true',
                     'gpgcheck' => '1',
                     'gpgkey'   => "file:///etc/pki/rpm-gpg/RPM-GPG-KEY-puppet\n  file:///etc/pki/rpm-gpg/RPM-GPG-KEY-puppet-20250406",
@@ -261,6 +261,24 @@
             is_expected.to contain_yumrepo('pc_repo').with_skip_if_unavailable(true)
           }
         end
+        describe 'with credentials' do
+          let(:params) do
+            {
+              manage_repo: true,
+              package_version: package_version,
+              username: 'forge-key',
+              password: sensitive('open-sesame'),
+            }
+          end
+
+          it {
+            is_expected.to contain_yumrepo('pc_repo')
+              .with(
+                username: 'forge-key',
+                password: sensitive('open-sesame'),
+              )
+          }
+        end
       end
 
       context 'with manage_repo disabled' do

spec/classes/puppet_agent_osfamily_suse_spec.rb

@@ -151,7 +151,7 @@
                   'enabled'     => '1',
                   'gpgcheck'    => '1',
                   'autorefresh' => '0',
-                  'baseurl'     => "http://yum.puppet.com/puppet6/sles/#{os_version}/x86_64?ssl_verify=no",
+                  'baseurl'     => "https://yum-puppetcore.puppet.com/puppet6/sles/#{os_version}/x86_64?ssl_verify=no",
                   'type'        => 'rpm-md',
                 }.each do |setting, value|
                   it {