Use Puppet version to determine collection in install_shell.sh

When a collection is not explicitly specified, determine the appropriate
collection based on the installed Puppet version rather than defaulting
to the generic 'puppet' collection. This ensures platforms like Ubuntu 24
use the correct version-specific package (e.g., puppet8-release) instead
of the generic package (puppet-release) which can cause failures.

Signed-off-by: Gavin Didrichsen <[email protected]>

Author: gavindidrichsen

tasks/install_shell.sh

@@ -120,7 +120,24 @@ if [ -n "$PT_collection" ]; then
 
   collection=$PT_collection
 else
-  collection='puppet'
+  # Try to determine the appropriate collection based on puppet version
+  # This helps ensure we use version-specific packages (e.g., puppet8-release) 
+  # rather than generic packages (puppet-release) which can fail on some platforms like Ubuntu 24
+  if [ -f /opt/puppetlabs/puppet/VERSION ]; then
+    puppet_version=`cat /opt/puppetlabs/puppet/VERSION`
+    major_version=`echo $puppet_version | cut -d. -f1`
+    collection="puppet${major_version}"
+    info "Setting collection to ${collection} based on installed Puppet version ${puppet_version}"
+  elif type -p puppet >/dev/null; then
+    puppet_version=`puppet --version`
+    major_version=`echo $puppet_version | cut -d. -f1`  
+    collection="puppet${major_version}"
+    info "Setting collection to ${collection} based on puppet command version ${puppet_version}"
+  else
+    # Default to generic collection as a last resort
+    collection='puppet'
+    info "No puppet version detected, using default collection: ${collection}"
+  fi
 fi
 
 if [ -n "$PT_yum_source" ]; then