(main) Remove the sort function

Prior to this commit, the sort function was used to sort the hosts
returned from the PuppetDB queries. This commit moves the logic to the
PuppetDB query to do the sorting and removes the sort function. This
fixes compatibility with 5.x that did not have the sort function.

Author: Jarret Lavallee

functions/hosts_with_pe_profile.pp

@@ -22,6 +22,7 @@ function puppet_metrics_collector::hosts_with_pe_profile($profile) {
                type = 'Class' and
                title = 'Puppet_enterprise::Profile::${_profile}' and
                nodes { deactivated is null and expired is null }
+               order by certname
               }").map |$nodes| { $nodes['certname'] }
   }
   else {

manifests/pe_metric.pp

@@ -47,7 +47,7 @@
     'metrics_type'           => $metrics_type,
     'pe_version'             => $facts['pe_server_version'],
     'clientcert'             => $::clientcert,
-    'hosts'                  => $hosts.sort(),
+    'hosts'                  => $hosts,
     'metrics_port'           => $metrics_port,
     'ssl'                    => $ssl,
     'excludes'               => $excludes,

metadata.json

@@ -7,8 +7,7 @@
   "source": "https://github.com/puppetlabs/puppetlabs-puppet_metrics_collector",
   "project_page": "https://github.com/puppetlabs/puppetlabs-puppet_metrics_collector",
   "issues_url": "https://github.com/puppetlabs/puppetlabs-puppet_metrics_collector/issues",
-  "dependencies": [
-  ],
+  "dependencies": [],
   "operatingsystem_support": [
     {
       "operatingsystem": "RedHat",