Merge pull request #115 from carabasdaniel/main

Add pe_metric acceptance test and improve init spec test

Author: jarretlavallee

spec/acceptance/functions/hosts_with_pe_profile_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper_acceptance'
+
+describe 'hosts_with_pe_profile function' do
+  it 'returns 127.0.0.1 when no hosts are found' do
+    pp = <<-MANIFEST
+       $result=puppet_metrics_collector::hosts_with_pe_profile('non_existant')
+       notice "Received=$result"
+       MANIFEST
+    output = apply_manifest(pp).stdout
+    expect(output).to match(%r{127.0.0.1})
+  end
+  it 'return the FQDN for the master profile' do
+    # This influences the custom facts
+    run_shell('puppet config set storeconfigs true --section user', expect_failures: false)
+    pp = <<-MANIFEST
+       $result=puppet_metrics_collector::hosts_with_pe_profile('master')
+       notice "Received=$result"
+       MANIFEST
+    output = apply_manifest(pp).stdout
+    expect(output).to match(host_inventory['fqdn'])
+    run_shell('puppet config set storeconfigs false --section user', expect_failures: false)
+  end
+end

spec/acceptance/init_spec.rb

@@ -8,14 +8,17 @@
         MANIFEST
 
       # Run it twice and test for idempotency
-      expect(apply_manifest(pp).exit_code).not_to eq(1)
-      expect(apply_manifest(pp).exit_code).not_to eq(1)
       idempotent_apply(pp)
     end
     describe 'check systemd fact' do
       it 'is true on all supported OS' do
         expect(host_inventory['facter']['puppet_metrics_collector']['have_systemd']).to eq true
       end
     end
+    describe 'check puppet-metrics-collector directory' do
+      it 'scripts folder exists' do
+        file('/opt/puppetlabs/puppet-metrics-collector/scripts').should be_directory
+      end
+    end
   end
 end

spec/acceptance/pe_metric_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper_acceptance'
+
+describe 'test default and system includes' do
+  before(:all) do
+    pp = <<-MANIFEST
+        include puppet_metrics_collector
+        include puppet_metrics_collector::system
+        MANIFEST
+    idempotent_apply(pp)
+  end
+  it 'sets all puppet_* metric services to be active' do
+    run_shell('systemctl list-units --type=service | grep "puppet_.*metrics"') do |r|
+      puts r.stdout
+      expect(r.stdout).to match(%r{activ})
+    end
+  end
+  it 'check for the tidy services files' do
+    files = run_shell('ls /etc/systemd/system/puppet_*-tidy.service').stdout
+    expect(files.split("\n").count).to eq(9)
+  end
+  it 'check for the timer files' do
+    files = run_shell('ls /etc/systemd/system/puppet_*-tidy.timer').stdout
+    expect(files.split("\n").count).to eq(9)
+  end
+  it 'checks if sysstat package is installed' do
+    expect(package('sysstat')).to be_installed
+  end
+end