(maint) Rubocop fixes

Author: david22swan

.rubocop_todo.yml

@@ -1,11 +1,16 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-11-28 17:42:38 UTC using RuboCop version 1.48.1.
+# on 2025-10-01 10:09:02 UTC using RuboCop version 1.73.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 4
+RSpec/ExpectInLet:
+  Exclude:
+    - 'spec/defines/config/server/service_spec.rb'
+
 # Offense count: 128
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only

spec/acceptance/acceptance_1_readme_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper_acceptance'
 
 confine_array = [
-  (os[:family] =~ %r{debian|ubuntu} &&  os[:release] == '18.04'),
-  (os[:family].include?('redhat')   &&  os[:release].start_with?('5')),
+  os[:family] =~ %r{debian|ubuntu} &&  os[:release] == '18.04',
+  os[:family].include?('redhat')   &&  os[:release].start_with?('5'),
 ]
 stop_test = confine_array.any?
 

spec/spec_helper_acceptance_local.rb

@@ -61,12 +61,12 @@ def latest_tomcat_tarball_url(version)
   require 'net/http'
   page = Net::HTTP.get(URI("https://tomcat.apache.org/download-#{version}0.cgi"))
 
-  url = ((match = page.match(%r{https?://.*?apache-tomcat-(.{4,9}).tar.gz})) && match[0])
+  url = (match = page.match(%r{https?://.*?apache-tomcat-(.{4,9}).tar.gz})) && match[0]
   return url if url
 
-  mirror_url = ((match = page.match(%r{<strong>(https?://.*?)/</strong>})) && match[1])
+  mirror_url = (match = page.match(%r{<strong>(https?://.*?)/</strong>})) && match[1]
   page = Net::HTTP.get(URI("#{mirror_url}/tomcat/tomcat-#{version}/"))
-  latest_version = ((match = page.match(%r{href="v(.{4,9})/"})) && match[1])
+  latest_version = (match = page.match(%r{href="v(.{4,9})/"})) && match[1]
 
   "#{mirror_url}/tomcat/tomcat-#{version}/v#{latest_version}/bin/apache-tomcat-#{latest_version}.tar.gz"
 end