Merge pull request #106 from voreilly/main

Update legacy facts to be compatible with Puppet 8

Author: malikparvez

lib/facter/windows_env.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 Facter.add('windows_env') do
-  confine osfamily: :windows
+  confine 'os.family': :windows
   setcode do
     require 'puppet/util/windows/process'
 

lib/puppet/provider/windows_env/windows_env.rb

@@ -43,8 +43,8 @@ def evaluate
   desc 'Manage Windows environment variables'
 
   confine feature: :windows_env
-  confine osfamily: :windows
-  defaultfor osfamily: :windows
+  confine 'os.family': :windows
+  defaultfor 'os.family': :windows
 
   # For testing registry open result
   ERROR_FILE_NOT_FOUND = 2