(maint) Switch to rspec-mocks

Author: GabrielNagy

spec/lib/puppet_spec/compiler.rb

@@ -19,7 +19,7 @@ def apply_compiled_manifest(manifest, prioritizer = Puppet::Graph::SequentialPri
     if Puppet.version.to_f < 5.0
       args << 'apply'
       # rubocop:disable RSpec/AnyInstance
-      Puppet::Transaction::Persistence.any_instance.stubs(:save)
+      allow_any_instance_of(Puppet::Transaction::Persistence).to receive(:save)
       # rubocop:enable RSpec/AnyInstance
     end
     catalog = compile_to_ral(manifest)
@@ -37,7 +37,7 @@ def apply_compiled_manifest(manifest, prioritizer = Puppet::Graph::SequentialPri
 
   def apply_with_error_check(manifest)
     apply_compiled_manifest(manifest) do |res|
-      res.expects(:err).never
+      expect(res).not_to receive(:err)
     end
   end
 end

spec/lib/puppet_spec/files.rb

@@ -11,7 +11,7 @@ def self.cleanup
     until @global_tempfiles.empty?
       path = @global_tempfiles.pop
       begin
-        Dir.unstub(:entries)
+        allow(Dir).to receive(:entries).and_call_original
         FileUtils.rm_rf path, secure: true
       end
     end

spec/spec_helper.rb

@@ -31,6 +31,7 @@
 end
 
 RSpec.configure do |c|
+  c.mock_with :rspec
   c.default_facts = default_facts
   c.before :each do
     # set to strictest setting for testing