Stop using legacy facts

Author: tvpartytonight

lib/puppet/type/yumrepo.rb

@@ -324,7 +324,7 @@
     newvalues(%r{.*}, :absent)
     validate do |value|
       next if %r{^(absent|_none_)$}.match?(value.to_s)
-      next if value.to_s.empty? && Facter.value(:operatingsystemmajrelease).to_i >= 8
+      next if value.to_s.empty? && Facter.value('os.distro.release.major').to_i >= 8
 
       parsed = URI.parse(value)
       unless VALID_SCHEMES.include?(parsed.scheme)
@@ -333,7 +333,7 @@
     end
 
     munge do |value|
-      return '' if Facter.value(:operatingsystemmajrelease).to_i >= 8 && value.to_s == '_none_'
+      return '' if Facter.value('os.distro.release.major').to_i >= 8 && value.to_s == '_none_'
       super(value)
     end
   end

spec/unit/type/yumrepo_spec.rb

@@ -327,13 +327,13 @@
       end
 
       it "munges '_none_' to empty string for EL >= 8" do
-        allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return('8')
+        allow(Facter).to receive(:value).with('os.distro.release.major').and_return('8')
         instance = described_class.new(name: 'puppetlabs', proxy: '_none_')
         expect(instance[:proxy]).to eq ''
       end
 
       it "does not munge '_none_' to empty string for EL < 8" do
-        allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return('7')
+        allow(Facter).to receive(:value).with('os.distro.release.major').and_return('7')
         instance = described_class.new(name: 'puppetlabs', proxy: '_none_')
         expect(instance[:proxy]).to eq '_none_'
       end