Stop using legacy facts

Author: tvpartytonight

lib/puppet/provider/zfs/zfs.rb

@@ -42,7 +42,7 @@ def exists?
 
   # On FreeBSD zoned is called jailed
   def container_property
-    case Facter.value(:operatingsystem)
+    case Facter.value('os.name')
     when 'FreeBSD'
       :jailed
     else

spec/unit/provider/zfs/zfs_spec.rb

@@ -112,7 +112,7 @@
   describe 'zoned' do
     context 'on FreeBSD' do
       before(:each) do
-        allow(Facter).to receive(:value).with(:operatingsystem).and_return('FreeBSD')
+        allow(Facter).to receive(:value).with('os.name').and_return('FreeBSD')
       end
       it "gets 'jailed' property" do
         expect(provider).to receive(:zfs).with(:get, '-H', '-o', 'value', :jailed, name).and_return("value\n")
@@ -127,7 +127,7 @@
 
     context 'when not running FreeBSD' do
       before(:each) do
-        allow(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
+        allow(Facter).to receive(:value).with('os.name').and_return('Solaris')
       end
       it "gets 'zoned' property" do
         expect(provider).to receive(:zfs).with(:get, '-H', '-o', 'value', :zoned, name).and_return("value\n")