Skip to content

Commit 707883f

Browse files
authored
Merge pull request #66 from murkyway/nvme_support
2 parents 56d058c + d3a6505 commit 707883f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/puppet/provider/zpool/zpool.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def process_zpool_data(pool_array)
4444
pool[:raid_parity] = 'raidz2' if %r{^raidz2}.match?(value)
4545
else
4646
# get full drive name if the value is a partition (Linux only)
47-
tmp << if Facter.value(:kernel) == 'Linux' && value =~ %r{/dev/(:?[a-z]+1|disk/by-id/.+-part1)$}
47+
tmp << if Facter.value(:kernel) == 'Linux' && value =~ %r{/dev/(:?[a-z]+([0-9]+n[0-9]+p)?1|disk/by-id/.+-part1)$}
4848
execute("lsblk -p -no pkname #{value}").chomp
4949
else
5050
value

spec/unit/provider/zpool/zpool_spec.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,10 @@
6363
describe 'when there are full path disks on Linux' do
6464
it 'munges partitions into disk names' do
6565
allow(provider).to receive(:execute).with('lsblk -p -no pkname /dev/sdc1').and_return('/dev/sdc')
66+
allow(provider).to receive(:execute).with('lsblk -p -no pkname /dev/nvme0n1p1').and_return('/dev/nvme0n1')
6667
allow(provider).to receive(:execute).with('lsblk -p -no pkname /dev/disk/by-id/disk_serial-0:0-part1').and_return('/dev/disk/by-id/disk_serial-0:0')
67-
zpool_data = ['foo', '/dev/sdc1', '/dev/disk/by-id/disk_serial-0:0-part1']
68-
expect(provider.process_zpool_data(zpool_data)[:disk]).to eq(['/dev/sdc /dev/disk/by-id/disk_serial-0:0'])
68+
zpool_data = ['foo', '/dev/sdc1', '/dev/nvme0n1p1', '/dev/disk/by-id/disk_serial-0:0-part1']
69+
expect(provider.process_zpool_data(zpool_data)[:disk]).to eq(['/dev/sdc /dev/nvme0n1 /dev/disk/by-id/disk_serial-0:0'])
6970
end
7071
end
7172

0 commit comments

Comments
 (0)