Address Rubocop offenses

This commit addresses the following Rubocop offenses:

- Performance/StringInclude
- Style/ClassAndModuleChildren
- Style/TernaryParentheses

Author: mhashizume

lib/puppet/provider/zone/solaris.rb

@@ -320,7 +320,7 @@ def config_status
     config = getconfig
     result = {}
 
-    result[:autoboot] = (config[:autoboot]) ? config[:autoboot].to_sym : :true
+    result[:autoboot] = config[:autoboot] ? config[:autoboot].to_sym : :true
     result[:pool] = config[:pool]
     result[:shares] = config[:shares]
     dir = config['inherit-pkg-dir']

lib/puppet/type/zone.rb

@@ -6,7 +6,7 @@
 the zone's filesystem (with the `path` attribute), the zone resource will
 autorequire that directory."
 
-  module Puppet::Zone
+  module Puppet::Zone # rubocop:disable Style/ClassAndModuleChildren
     # Zone state machine
     class StateMachine
       # A silly little state machine.
@@ -200,7 +200,7 @@ def insync?(is)
     end
 
     munge do |value|
-      if %r{%s}.match?(value)
+      if value.include?('%s')
         value % @resource[:name]
       else
         value

spec/acceptance/tests/zone_configured_spec.rb

@@ -10,7 +10,7 @@
 
   # inherit /sbin on solaris10 until PUP-3722
   def config_inherit_string(agent)
-    if %r{solaris-10}.match?(agent['platform'])
+    if agent['platform'].include?('solaris-10')
       "inherit => '/sbin'"
     else
       ''

spec/acceptance/tests/zone_running_spec.rb

@@ -10,7 +10,7 @@
 
   # inherit /sbin on solaris10 until PUP-3722
   def config_inherit_string(agent)
-    if %r{solaris-10}.match?(agent['platform'])
+    if agent['platform'].include?('solaris-10')
       "inherit => '/sbin'"
     else
       ''