(CONT-807) Correct RSpec/HookArgument

Author: chelnak

spec/unit/puppetlabs_spec_helper/tasks/check_symlinks_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'rake check:symlinks', type: :task do
-  before(:each) do
+  before do
     test_files.each do |f|
       FileUtils.mkdir_p(File.dirname(f))
       FileUtils.touch(f)
@@ -115,7 +115,7 @@
   end
 
   context 'when there are symlinks under a directory listed in .gitignore' do
-    before(:each) do
+    before do
       File.write(File.join(Dir.pwd, '.gitignore'), "a_directory/\n")
     end
 
@@ -137,7 +137,7 @@
   end
 
   context 'when there are symlinks under a directory listed in .pdkignore' do
-    before(:each) do
+    before do
       File.open(File.join(Dir.pwd, '.pdkignore'), 'w') do |f|
         f.puts '/another_directory/'
       end

spec/unit/puppetlabs_spec_helper/tasks/check_test_file_spec.rb

@@ -4,7 +4,7 @@
 
 describe 'rake check:test_file', type: :task do
   context 'when there are .pp files under tests/' do
-    before(:each) do
+    before do
       test_files.each do |f|
         FileUtils.mkdir_p(File.dirname(f))
         FileUtils.touch(f)
@@ -28,7 +28,7 @@
   end
 
   context 'when there are no .pp files under tests/' do
-    before(:each) do
+    before do
       FileUtils.mkdir('tests')
     end
 

spec/unit/puppetlabs_spec_helper/tasks/fixture_helpers_spec.rb

@@ -7,7 +7,7 @@
   describe '.module_name' do
     subject(:module_name) { described_class.module_name }
 
-    before(:each) do
+    before do
       allow(Dir).to receive(:pwd).and_return(File.join('path', 'to', 'my-awsome-module_from_pwd'))
     end
 
@@ -24,28 +24,28 @@
     end
 
     context 'when metadata.json does not exist' do
-      before(:each) do
+      before do
         allow(File).to receive(:file?).with('metadata.json').and_return(false)
       end
 
       it_behaves_like 'module name from working directory'
     end
 
     context 'when metadata.json does exist' do
-      before(:each) do
+      before do
         allow(File).to receive(:file?).with('metadata.json').and_return(true)
       end
 
       context 'when it is not readable' do
-        before(:each) do
+        before do
           allow(File).to receive(:readable?).with('metadata.json').and_return(false)
         end
 
         it_behaves_like 'module name from working directory'
       end
 
       context 'when it is readable' do
-        before(:each) do
+        before do
           allow(File).to receive(:readable?).with('metadata.json').and_return(true)
           allow(File).to receive(:read).with('metadata.json').and_return(metadata_content)
         end
@@ -86,7 +86,7 @@
   describe '.fixtures' do
     subject(:helper) { described_class }
 
-    before :each do
+    before do
       # Unstub the fixtures "helpers"
       PuppetlabsSpec::Fixtures.instance_methods.each do |m|
         PuppetlabsSpec::Fixtures.send(:undef_method, m)
@@ -166,7 +166,7 @@
     end
 
     context 'when file specifies repository fixtures' do
-      before(:each) do
+      before do
         allow(File).to receive(:exist?).with('.fixtures.yml').and_return true
         allow(YAML).to receive(:load_file).with('.fixtures.yml').and_return(
           'fixtures' => {
@@ -190,7 +190,7 @@
     end
 
     context 'when file specifies repository fixtures with an invalid git ref' do
-      before(:each) do
+      before do
         allow(File).to receive(:exist?).with('.fixtures.yml').and_return true
         allow(YAML).to receive(:load_file).with('.fixtures.yml').and_return(
           'fixtures' => {