(CONT-807) Correct Style/RegexpLiteral

Author: chelnak

lib/puppetlabs_spec_helper/module_spec_helper.rb

@@ -56,7 +56,7 @@ def verify_contents(subject, title, expected_lines)
 components = module_path.split(File::PATH_SEPARATOR).map do |dir|
   next unless Dir.exist? dir
 
-  Dir.entries(dir).grep_v(%r{^\.}).map { |f| File.join(dir, f, 'spec', 'lib') }
+  Dir.entries(dir).grep_v(/^\./).map { |f| File.join(dir, f, 'spec', 'lib') }
 end
 components.flatten.each do |d|
   $LOAD_PATH << d if FileTest.directory?(d) && !$LOAD_PATH.include?(d)

lib/puppetlabs_spec_helper/rake_tasks.rb

@@ -227,7 +227,7 @@
     version = modinfo['version']
   elsif File.exist?('Modulefile')
     modfile = File.read('Modulefile')
-    version = modfile.match(%r{\nversion +['"](.*)['"]})[1]
+    version = modfile.match(/\nversion +['"](.*)['"]/)[1]
   else
     raise 'Could not find a metadata.json or Modulefile! Cannot compute dev version without one or the other!'
   end

lib/puppetlabs_spec_helper/tasks/check_symlinks.rb

@@ -26,7 +26,7 @@ def check(dir = Dir.pwd)
 
           if child.symlink?
             results << child
-          elsif child.directory? && child.basename.to_s !~ %r{^(\.git|\.?bundle)$}
+          elsif child.directory? && child.basename.to_s !~ /^(\.git|\.?bundle)$/
             results.concat(check(child))
           end
         end

spec/acceptance/smoke_spec.rb

@@ -9,6 +9,6 @@
     Open3.capture2e('rake', '--rakefile', 'spec/acceptance/fixtures/Rakefile', '-T')
   end
 
-  it { expect(output[0]).to match %r{spec_prep} }
+  it { expect(output[0]).to match(/spec_prep/) }
   it { expect(output[1]).to be_success }
 end

spec/unit/puppetlabs_spec_helper/tasks/check_symlinks_spec.rb

@@ -55,7 +55,7 @@
 
     it 'raises an error' do
       expect { task.execute }
-        .to raise_error(%r{symlink\(s\) exist}i)
+        .to raise_error(/symlink\(s\) exist/i)
         .and output(a_string_including(expected_output)).to_stdout
     end
   end

spec/unit/puppetlabs_spec_helper/tasks/check_test_file_spec.rb

@@ -22,7 +22,7 @@
       expected_output = test_files.join("\n")
 
       expect { task.execute }
-        .to raise_error(%r{pp files present in tests folder})
+        .to raise_error(/pp files present in tests folder/)
         .and output(a_string_including(expected_output)).to_stdout
     end
   end

spec/unit/puppetlabs_spec_helper/tasks/fixture_helpers_spec.rb

@@ -118,15 +118,15 @@
       it 'raises an error' do
         expect(File).to receive(:exist?).with('.fixtures.yml').and_return true
         expect(YAML).to receive(:load_file).with('.fixtures.yml').and_raise(Psych::SyntaxError.new('/file', '123', '0', '0', 'spec message', 'spec context'))
-        expect { helper.fixtures('forge_modules') }.to raise_error(RuntimeError, %r{malformed YAML})
+        expect { helper.fixtures('forge_modules') }.to raise_error(RuntimeError, /malformed YAML/)
       end
     end
 
     context 'when file contains no fixtures' do
       it 'raises an error' do
         allow(File).to receive(:exist?).with('.fixtures.yml').and_return true
         allow(YAML).to receive(:load_file).with('.fixtures.yml').and_return('some' => 'key')
-        expect { helper.fixtures('forge_modules') }.to raise_error(RuntimeError, %r{No 'fixtures'})
+        expect { helper.fixtures('forge_modules') }.to raise_error(RuntimeError, /No 'fixtures'/)
       end
     end
 

spec/watchr.rb

@@ -10,7 +10,7 @@ def growl(message)
   growlnotify = `which growlnotify`.chomp
   title = 'Watchr Test Results'
   image = case message
-          when %r{(\d+)\s+?(failure|error)}i
+          when /(\d+)\s+?(failure|error)/i
             (Regexp.last_match(1).to_i == 0) ? '~/.watchr_images/passed.png' : '~/.watchr_images/failed.png'
           else
             '~/.watchr_images/unknown.png'
@@ -35,7 +35,7 @@ def run_spec_test(file)
 end
 
 def filter_rspec(data)
-  data.split("\n").grep(%r{^(\d+)\s+exampl\w+.*?(\d+).*?failur\w+.*?(\d+).*?pending}).join("\n")
+  data.split("\n").grep(/^(\d+)\s+exampl\w+.*?(\d+).*?failur\w+.*?(\d+).*?pending/).join("\n")
 end
 
 def run_all_tests