(SERVER-3050) Bypass the fact cache in the v4 catalog endpoint

When we stopped explicitly querying the PuppetDB terminus for facts, we
inadventently started using the yaml cache terminus instead of PuppetDB,
even when PuppetDB was configured. However, trusted facts are not stored
in the yaml cache, and the primary use case for this endpoint requires
stored trusted facts to be retrieved from the system. So this commit
updates the fact retrieval to bypass the cache terminus for facts, going
instead directly to the primary terminus.

When PuppetDB is configured, this means we will query PDB for facts,
rather than the default yaml cache, and therefore retrieve its stored
trusted facts.

Author: Magisus

src/ruby/puppetserver-lib/puppet/server/compiler.rb

@@ -208,8 +208,10 @@ def extract_trusted_facts(request_data, facts)
       end
 
       def get_facts_from_terminus(nodename, environment)
+        # Ignore the cache terminus, which is not guaranteed to store trusted facts
         facts = Puppet::Node::Facts.indirection.find(nodename,
-                                                     {environment: environment})
+                                                     {environment: environment,
+                                                      ignore_cache: true})
 
         # If no facts have been stored for the node, the terminus will return nil
         if facts.nil?