(maint) update tests for newer beaker & minitest

This patch contains two changes:
1. Beaker TestCases used to have the methods `stdout`, `stderr`, and
   `exit_code` defined on them. These methods would delegate to the
   result of the last host command (usually executed via the `on`
   helper). Those delegating readers were like magical global variables,
   akin to Ruby's $1 returning the first match group of the last regex
   performed. These have been removed. Instead we have one of two
   options. `on` and friends will return a result object with `stdout`,
   etc defined on it, OR we can pass a block to `on` and it will pass a
   result object to the given block. We do whichever was most expedient.
2. The regex assertion `assert_no_match` has become `refute_match`.

Author: justinstoller

acceptance/lib/helper.rb

@@ -229,8 +229,7 @@ def get_defaults_file
   def get_defaults_var(host, varname)
     defaults_file = get_defaults_file
 
-    on(host, "source #{defaults_file}; echo -n $#{varname}")
-    stdout
+    on(host, "source #{defaults_file}; echo -n $#{varname}").stdout
   end
 
   # If we are getting the certificate for the first time, store it in the

acceptance/lib/puppetserver/acceptance/gem_utils.rb

@@ -7,8 +7,8 @@ def get_gem_list(host, gem_list_command)
   #
   gem_list_regex = Regexp.new('(?<package>[\w-]*) (?<version>.*)')
   array = []
-  on(host, "#{gem_list_command}") do
-    split_output = stdout.split
+  on(host, "#{gem_list_command}") do |result|
+    split_output = result.stdout.split
     split_output.each do |line|
       match = gem_list_regex.match(line)
       if match

acceptance/suites/puppet3_tests/puppet3_version_test.rb

@@ -4,13 +4,13 @@
 legacy_agents = agents.reject { |agent| agent == master }
 
 step "Check that legacy agents have Puppet 3.x installed"
-on(legacy_agents, puppet("--version")) do
-  assert(stdout.start_with? "3.", "puppet --version does not start with major version 3.")
+on(legacy_agents, puppet("--version")) do |result|
+  assert(result.stdout.start_with? "3.", "puppet --version does not start with major version 3.")
 end
 
 step "Check that Puppet Server has Puppet 6.x installed"
-on(master, puppet("--version")) do
-  assert_match(/\A6/, stdout, "puppet --version does not start with major version 6.x")
+on(master, puppet("--version")) do |result|
+  assert_match(/\A6/, result.stdout, "puppet --version does not start with major version 6.x")
 end
 
 step "Check that the agent on the master runs against the master"

acceptance/suites/tests/00_smoke/puppetdb_integration.rb

@@ -101,8 +101,8 @@
     # ISO 8601 timestamp, with milliseconds and time zone. Local time is used
     # instead of UTC as both PuppetDB and Puppet Server log in local time.
     run_timestamp = Time.iso8601(on(master, 'date +"%Y-%m-%dT%H:%M:%S.%3N%:z"').stdout.chomp)
-    on(master, puppet_agent("--test"), :acceptable_exit_codes => [0,2]) do
-      assert_match(/Notice: #{random_string}/, stdout,
+    on(master, puppet_agent("--test"), :acceptable_exit_codes => [0,2]) do |result|
+      assert_match(/Notice: #{random_string}/, result.stdout,
                   'Puppet run collects exported Notify')
     end
   end

acceptance/suites/tests/010-puppetserver-cli/subcommand/SERVER-297_common_behavior.rb

@@ -5,8 +5,8 @@
 proxy_env_vars = "HTTP_PROXY=foo http_proxy=foo HTTPS_PROXY=foo https_proxy=foo NO_PROXY=foo no_proxy=foo"
 
 step "ruby: Check that PATH, HOME, GEM_HOME JARS_REQUIRE and JARS_NO_REQUIRE are present"
-on(master, "puppetserver ruby -rjson -e 'puts JSON.pretty_generate(ENV.to_hash)'") do
-  env = JSON.parse(stdout)
+on(master, "puppetserver ruby -rjson -e 'puts JSON.pretty_generate(ENV.to_hash)'") do |result|
+  env = JSON.parse(result.stdout)
   assert(env['PATH'], "PATH missing")
   assert(env['HOME'], "HOME missing")
   assert(env['GEM_HOME'], "GEM_HOME missing")
@@ -15,8 +15,8 @@
 end
 
 step "ruby: Check that proxy env-variables are present"
-on(master, "#{proxy_env_vars} puppetserver ruby -rjson -e 'puts JSON.pretty_generate(ENV.to_hash)'") do
-  env = JSON.parse(stdout)
+on(master, "#{proxy_env_vars} puppetserver ruby -rjson -e 'puts JSON.pretty_generate(ENV.to_hash)'") do |result|
+  env = JSON.parse(result.stdout)
   assert_equal(env['HTTP_PROXY'], "foo",
                "HTTP_PROXY is missing or has wrong value: '#{env['HTTP_PROXY']}'")
   assert_equal(env['http_proxy'], "foo",
@@ -32,20 +32,20 @@
 end
 
 step "irb: Check that PATH, HOME, GEM_HOME JARS_REQUIRE and JARS_NO_REQUIRE are present"
-on(master, "echo 'puts JSON.pretty_generate(ENV.to_hash)' | puppetserver irb -f -rjson") do
-  assert_match(/\bPATH\b/, stdout, "PATH missing")
-  assert_match(/\bHOME\b/, stdout, "HOME missing")
-  assert_match(/\bGEM_HOME\b/, stdout, "GEM_HOME missing")
-  assert_match(/\bJARS_REQUIRE\b/, stdout, "JARS_REQUIRE missing")
-  assert_match(/\bJARS_NO_REQUIRE\b/, stdout, "JARS_NO_REQUIRE missing")
+on(master, "echo 'puts JSON.pretty_generate(ENV.to_hash)' | puppetserver irb -f -rjson") do |result|
+  assert_match(/\bPATH\b/, result.stdout, "PATH missing")
+  assert_match(/\bHOME\b/, result.stdout, "HOME missing")
+  assert_match(/\bGEM_HOME\b/, result.stdout, "GEM_HOME missing")
+  assert_match(/\bJARS_REQUIRE\b/, result.stdout, "JARS_REQUIRE missing")
+  assert_match(/\bJARS_NO_REQUIRE\b/, result.stdout, "JARS_NO_REQUIRE missing")
 end
 
 step "irb: Check that proxy env-variables are present"
-on(master, "echo 'puts JSON.pretty_generate(ENV.to_hash)' | #{proxy_env_vars} puppetserver irb -f -rjson") do
-  assert_match(/\bHTTP_PROXY\b\W\W\s\W\bfoo\b/, stdout, "HTTP_PROXY missing or has wrong value")
-  assert_match(/\bhttp_proxy\b\W\W\s\W\bfoo\b/, stdout, "http_proxy missing or has wrong value")
-  assert_match(/\bHTTPS_PROXY\b\W\W\s\W\bfoo\b/, stdout, "HTTPS_PROXY missing or has wrong value")
-  assert_match(/\bhttps_proxy\b\W\W\s\W\bfoo\b/, stdout, "https_proxy missing or has wrong value")
-  assert_match(/\bNO_PROXY\b\W\W\s\W\bfoo\b/, stdout, "NO_PROXY missing or has wrong value")
-  assert_match(/\bno_proxy\b\W\W\s\W\bfoo\b/, stdout, "no_proxy missing or has wrong value")
+on(master, "echo 'puts JSON.pretty_generate(ENV.to_hash)' | #{proxy_env_vars} puppetserver irb -f -rjson") do |result|
+  assert_match(/\bHTTP_PROXY\b\W\W\s\W\bfoo\b/, result.stdout, "HTTP_PROXY missing or has wrong value")
+  assert_match(/\bhttp_proxy\b\W\W\s\W\bfoo\b/, result.stdout, "http_proxy missing or has wrong value")
+  assert_match(/\bHTTPS_PROXY\b\W\W\s\W\bfoo\b/, result.stdout, "HTTPS_PROXY missing or has wrong value")
+  assert_match(/\bhttps_proxy\b\W\W\s\W\bfoo\b/, result.stdout, "https_proxy missing or has wrong value")
+  assert_match(/\bNO_PROXY\b\W\W\s\W\bfoo\b/, result.stdout, "NO_PROXY missing or has wrong value")
+  assert_match(/\bno_proxy\b\W\W\s\W\bfoo\b/, result.stdout, "no_proxy missing or has wrong value")
 end

acceptance/suites/tests/010-puppetserver-cli/subcommand/foreground.rb

@@ -1,9 +1,5 @@
 test_name "Puppetserver 'foreground' subcommand tests."
 
-if (master['platform'] =~ /el-5/)
-  skip_test("RHEL5 is not supported by this test case. See SERVER-653")
-end
-
 cli = "puppetserver"
 service = options['puppetservice']
 
@@ -25,7 +21,7 @@
 
 step "Run #{cli} with foreground subcommand, wait for #{timout_length}"
 on(master, timeout_cmd, :acceptable_exit_codes => [124]) do |result|
-  assert_no_match(/error:/i, result.stderr, "Unexpected error running puppetserver!")
+  refute_match(/error:/i, result.stderr, "Unexpected error running puppetserver!")
 
   step "Check that #{cli} ran successfully and shutdown triggered"
   expected_messages.each do |message, explanation|

acceptance/suites/tests/010-puppetserver-cli/subcommand/gem.rb

@@ -43,8 +43,8 @@
   on(master, "#{gem_install} #{gem_name} -v #{gem_version}")
 
   step "Check that test gem is present."
-  on(master, "#{gem_list}") do
-    assert(/^#{gem_name}/.match(stdout), "#{gem_name} was not found after installation.")
+  on(master, "#{gem_list}") do |result|
+    assert(/^#{gem_name}/.match(result.stdout), "#{gem_name} was not found after installation.")
   end
 
   if gem_name == 'excon'
@@ -56,8 +56,8 @@
       end
       on(master, "su #{runuser} -s /bin/bash -c "\
         "'/opt/puppetlabs/bin/puppetserver ruby "\
-        "-rexcon -e \"puts Excon::VERSION\"'") do
-        assert_equal(gems['excon'], stdout.strip,
+        "-rexcon -e \"puts Excon::VERSION\"'") do |result|
+        assert_equal(gems['excon'], result.stdout.strip,
                      "Unexpected output for excon version")
       end
     end
@@ -67,8 +67,8 @@
   on(master, "#{gem_uninstall} #{gem_name}")
 
   step "Check that test gem is no longer present."
-  on(master, "#{gem_list}") do
-    assert_no_match(/^#{gem_name}/, stdout, "#{gem_name} was found after uninstallation.")
+  on(master, "#{gem_list}") do |result|
+    refute_match(/^#{gem_name}/, result.stdout, "#{gem_name} was found after uninstallation.")
   end
 end
 
@@ -88,14 +88,14 @@
 on(master, "#{cli} gem env", :acceptable_exit_codes => [0])
 
 step "Verify that Java cli args passed through to gem command"
-on(master, "JAVA_ARGS_CLI=-Djruby.cli.version=true #{cli} gem help") do
-  assert_match(/jruby \d\.\d\.\d.*$/, stdout,
+on(master, "JAVA_ARGS_CLI=-Djruby.cli.version=true #{cli} gem help") do |result|
+  assert_match(/jruby \d\.\d\.\d.*$/, result.stdout,
                'jruby version not included in gem command output')
 end
 
 step "(SERVER-1759) Verify that installing a non-existent gem produces a non-zero exit return value"
 
 gem_name = 'if-this-gem-exists-then-someone-has-a-cruel-sense-of-humor'
-on(master, "#{cli} gem install #{gem_name}", :acceptable_exit_codes => [2]) do
-  assert_match(/Could not find a valid gem/, stderr)
+on(master, "#{cli} gem install #{gem_name}", :acceptable_exit_codes => [2]) do |result|
+  assert_match(/Could not find a valid gem/, result.stderr)
 end

acceptance/suites/tests/010-puppetserver-cli/subcommand/irb.rb

@@ -10,28 +10,28 @@
 
 step "Check that GEM_HOME is managed"
 cmd = "echo 'puts ENV.to_hash.to_yaml' | GEM_HOME=UHOH #{cli} irb -ryaml -f"
-on(master, cmd) do
-  assert_match(/GEM_HOME/, stdout)
-  assert_no_match(/UHOH/, stdout)
+on(master, cmd) do |result|
+  assert_match(/GEM_HOME/, result.stdout)
+  refute_match(/UHOH/, result.stdout)
 end
 
 step "Check that FOO_DEBUG is filtered"
 cmd = "echo 'puts ENV[%{FOO_DEBUG}] || %{OK}' | FOO_DEBUG=BAD #{cli} irb -f"
-on(master, cmd) do
-  assert_match(/^OK$/, stdout)
-  assert_no_match(/^BAD$/, stdout, "FOO_DEBUG is not being filtered out")
+on(master, cmd) do |result|
+  assert_match(/^OK$/, result.stdout)
+  refute_match(/^BAD$/, result.stdout, "FOO_DEBUG is not being filtered out")
 end
 
 step "Check that puppet is loadable"
 cmd = "echo 'puts %{GOOD: } + Puppet.version' | #{cli} irb -rpuppet -f"
-on(master, cmd) do
-  assert_match(/GOOD:/, stdout)
-  assert_no_match(/error/i, stdout)
+on(master, cmd) do |result|
+  assert_match(/GOOD:/, result.stdout)
+  refute_match(/error/i, result.stdout)
 end
 
 step "Verify that Java cli args passed through to irb command"
-on(master, "echo '' | JAVA_ARGS_CLI=-Djruby.cli.version=true #{cli} irb -f") do
-  assert_match(/jruby \d\.\d\.\d.*$/, stdout,
+on(master, "echo '' | JAVA_ARGS_CLI=-Djruby.cli.version=true #{cli} irb -f") do |result|
+  assert_match(/jruby \d\.\d\.\d.*$/, result.stdout,
                'jruby version not included in irb command output')
 end
 

acceptance/suites/tests/010-puppetserver-cli/subcommand/ruby.rb

@@ -10,27 +10,27 @@
 
 step "Check that GEM_HOME is managed"
 cmd = "GEM_HOME=UHOH #{cli} ruby -ryaml -e 'puts ENV.to_hash.to_yaml'"
-on(master, cmd) do
-  assert_match(/GEM_HOME/, stdout)
-  assert_no_match(/UHOH/, stdout)
+on(master, cmd) do |result|
+  assert_match(/GEM_HOME/, result.stdout)
+  refute_match(/UHOH/, result.stdout)
 end
 
 step "Check that FOO_DEBUG is filtered out"
-on(master, "FOO_DEBUG=BAD #{cli} ruby -e 'puts ENV[%{FOO_DEBUG}] || %{OK}'") do
-  assert_match(/^OK$/, stdout)
-  assert_no_match(/BAD/, stdout, "FOO_DEBUG is not being filtered out")
+on(master, "FOO_DEBUG=BAD #{cli} ruby -e 'puts ENV[%{FOO_DEBUG}] || %{OK}'") do |result|
+  assert_match(/^OK$/, result.stdout)
+  refute_match(/BAD/, result.stdout, "FOO_DEBUG is not being filtered out")
 end
 
 step "Check that puppet is loadable"
 cmd = "#{cli} ruby -rpuppet -e 'puts %{GOOD: } + Puppet.version'"
-on(master, cmd) do
-  assert_match(/GOOD:/, stdout)
-  assert_no_match(/error/i, stdout)
+on(master, cmd) do |result|
+  assert_match(/GOOD:/, result.stdout)
+  refute_match(/error/i, result.stdout)
 end
 
 step "Verify that Java cli args passed through to ruby command"
-on(master, "JAVA_ARGS_CLI=-Djruby.cli.version=true #{cli} ruby -e ''") do
-  assert_match(/jruby \d\.\d\.\d.*$/, stdout,
+on(master, "JAVA_ARGS_CLI=-Djruby.cli.version=true #{cli} ruby -e ''") do |result|
+  assert_match(/jruby \d\.\d\.\d.*$/, result.stdout,
                'jruby version not included in ruby command output')
 end