Merge branch 'main' into CONT-990-Pull_Requests_template

Author: LukasAud

.github/pull_request_template.md

@@ -12,4 +12,4 @@ Mention any related issues or pull requests.
 ## Checklist
 - [ ] 🟢 Spec tests.
 - [ ] 🟢 Acceptance tests.
-- [ ] Manually verified. (For example `puppet apply`)
+- [ ] Manually verified.

lib/rspec-puppet/matchers/compile.rb

@@ -96,7 +96,7 @@ def missing_dependencies?
           vertex.each do |param, value|
             next unless %i[require subscribe notify before].include? param
 
-            value = Array[value] unless value.is_a? Array
+            value = [value] unless value.is_a? Array
             value.each do |val|
               retval = true if val.is_a?(Puppet::Resource) && !resource_exists?(val, vertex)
             end

lib/rspec-puppet/matchers/create_generic.rb

@@ -290,7 +290,7 @@ def relationship_refs(resource, type, visited = Set.new)
 
         visited << resource.object_id
 
-        Array[resource[type]].flatten.compact.each do |r|
+        [resource[type]].flatten.compact.each do |r|
           results << canonicalize_resource_ref(r)
           results << relationship_refs(r, type, visited)
 

lib/rspec-puppet/support.rb

@@ -504,7 +504,7 @@ def munge_facts(facts)
     end
 
     def escape_special_chars(string)
-      string.gsub(/\$/, '\\$')
+      string.gsub('$', '\\$')
     end
 
     def rspec_compatibility