Merge pull request #69 from puppetlabs/cat-1404-fix_rubocop_nightly_failures

(CAT-1404)- Fix rubocop nightly failures

Author: david22swan

.rubocop_todo.yml

@@ -1,18 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-04-11 21:10:40 UTC using RuboCop version 1.50.0.
+# on 2023-09-12 16:05:07 UTC using RuboCop version 1.56.3.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# Configuration parameters: Severity, Include.
-# Include: **/*.gemspec
-Gemspec/RequiredRubyVersion:
-  Exclude:
-    - 'rspec-puppet.gemspec'
-
 # Offense count: 3
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
 Lint/DuplicateBranch:
@@ -28,6 +21,7 @@ Lint/EmptyBlock:
     - 'spec/unit/adapters_spec.rb'
 
 # Offense count: 3
+# Configuration parameters: AllowedParentClasses.
 Lint/MissingSuper:
   Exclude:
     - 'lib/rspec-puppet/errors.rb'
@@ -58,6 +52,7 @@ Lint/UnusedMethodArgument:
     - 'lib/rspec-puppet/support.rb'
 
 # Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Lint/UselessAssignment:
   Exclude:
     - 'lib/rspec-puppet/example/function_example_group.rb'
@@ -98,7 +93,7 @@ Metrics/MethodLength:
 # Offense count: 2
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 425
+  Max: 422
 
 # Offense count: 2
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
@@ -140,6 +135,7 @@ Naming/HeredocDelimiterNaming:
     - 'spec/unit/matchers/compile_spec.rb'
 
 # Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -180,9 +176,9 @@ RSpec/Be:
 # Offense count: 2
 RSpec/BeforeAfterAll:
   Exclude:
-    - 'spec/spec_helper.rb'
-    - 'spec/rails_helper.rb'
-    - 'spec/support/**/*.rb'
+    - '**/spec/spec_helper.rb'
+    - '**/spec/rails_helper.rb'
+    - '**/spec/support/**/*.rb'
     - 'spec/unit/coverage_spec.rb'
 
 # Offense count: 76
@@ -201,27 +197,6 @@ RSpec/DescribeClass:
 RSpec/ExampleLength:
   Max: 12
 
-# Offense count: 15
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
-  Exclude:
-    - 'spec/cache_spec.rb'
-    - 'spec/classes/test_multi_os.rb'
-    - 'spec/raw_string_spec.rb'
-    - 'spec/support_spec.rb'
-    - 'spec/unit/coverage_spec.rb'
-    - 'spec/unit/example/function_example_group_spec.rb'
-    - 'spec/unit/facter_impl_spec.rb'
-    - 'spec/unit/matchers/allow_value_spec.rb'
-    - 'spec/unit/matchers/count_generic_spec.rb'
-    - 'spec/unit/matchers/parameter_matcher_spec.rb'
-    - 'spec/unit/matchers/raise_error_spec.rb'
-    - 'spec/unit/matchers/run_spec.rb'
-    - 'spec/unit/monkey_patches/win32/taskscheduler_spec.rb'
-    - 'spec/unit/raw_string_spec.rb'
-    - 'spec/unit/sensitive_spec.rb'
-
 # Offense count: 2
 RSpec/ImplicitBlockExpectation:
   Exclude:
@@ -255,7 +230,7 @@ RSpec/MultipleDescribes:
     - 'spec/unit/adapters_spec.rb'
     - 'spec/unit/monkey_patches_spec.rb'
 
-# Offense count: 44
+# Offense count: 46
 RSpec/MultipleExpectations:
   Max: 8
 
@@ -302,6 +277,34 @@ RSpec/RepeatedExampleGroupDescription:
     - 'spec/classes/sysctl_common_spec.rb'
     - 'spec/defines/sysctl_before_spec.rb'
 
+# Offense count: 14
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
+# Include: **/*_spec.rb
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - '**/spec/routing/**/*'
+    - 'spec/cache_spec.rb'
+    - 'spec/raw_string_spec.rb'
+    - 'spec/support_spec.rb'
+    - 'spec/unit/coverage_spec.rb'
+    - 'spec/unit/example/function_example_group_spec.rb'
+    - 'spec/unit/facter_impl_spec.rb'
+    - 'spec/unit/matchers/allow_value_spec.rb'
+    - 'spec/unit/matchers/count_generic_spec.rb'
+    - 'spec/unit/matchers/parameter_matcher_spec.rb'
+    - 'spec/unit/matchers/raise_error_spec.rb'
+    - 'spec/unit/matchers/run_spec.rb'
+    - 'spec/unit/monkey_patches/win32/taskscheduler_spec.rb'
+    - 'spec/unit/raw_string_spec.rb'
+    - 'spec/unit/sensitive_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/SpecFilePathSuffix:
+  Exclude:
+    - 'spec/classes/test_multi_os.rb'
+
 # Offense count: 3
 RSpec/SubjectStub:
   Exclude:
@@ -336,6 +339,7 @@ Style/ClassVars:
     - 'lib/rspec-puppet/support.rb'
 
 # Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Style/CombinableLoops:
   Exclude:
     - 'spec/classes/catalogue_cache_spec.rb'
@@ -353,7 +357,7 @@ Style/FormatString:
   Exclude:
     - 'lib/rspec-puppet/coverage.rb'
 
-# Offense count: 14
+# Offense count: 15
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Exclude: