(CONT-704) - Disable all cops by default

Author: jordanbreen28

.github/workflows/ci.yml

@@ -17,28 +17,13 @@ jobs:
         puppet_gem_version:
           - '~> 6.0'
           - '~> 7.0'
-    name: "spec (ruby ${{ matrix.ruby_version }} | puppet ${{matrix.puppet_gem_version}})"
+        runs_on:
+          - "ubuntu-latest"
+          - "windows-latest"
+    name: "spec (${{ matrix.runs_on }} ruby ${{ matrix.ruby_version }} | puppet ${{matrix.puppet_gem_version}})"
     uses: "puppetlabs/cat-github-actions/.github/workflows/gem_ci.yml@main"
     secrets: "inherit"
     with:
       ruby_version: ${{ matrix.ruby_version }}
       puppet_gem_version: ${{ matrix.puppet_gem_version }}
-
-  acceptance:
-    needs: "spec"
-    strategy:
-      fail-fast: false
-      matrix:
-        os:
-          - "ubuntu-latest"
-          - "windows-2019"
-        ruby_version:
-          - "2.5"
-          - "2.7"
-    name: "acceptance (${{ matrix.os }} | ruby ${{ matrix.ruby_version }})"
-    uses: "puppetlabs/cat-github-actions/.github/workflows/gem_acceptance.yml@main"
-    secrets: "inherit"
-    with:
-      ruby_version: ${{ matrix.ruby_version }}
-      rake_task: 'acceptance:local_parallel'
-      runs_on: ${{ matrix.os }}
+      runs_on: ${{ matrix.runs_on }}

.github/workflows/nightly.yml

@@ -16,27 +16,13 @@ jobs:
         puppet_gem_version:
           - '~> 6.0'
           - '~> 7.0'
-    name: "spec (ruby ${{ matrix.ruby_version }} | puppet ${{matrix.puppet_gem_version}})"
-    uses: "puppetlabs/cat-github-actions/.github/workflows/gem_ci.yml@main"
-    secrets: "inherit"
-    with:
-      ruby_version: ${{ matrix.ruby_version }}
-
-  acceptance:
-    needs: "spec"
-    strategy:
-      fail-fast: false
-      matrix:
-        os:
+        runs_on:
           - "ubuntu-latest"
-          - "windows-2019"
-        ruby_version:
-          - "2.5"
-          - "2.7"
-    name: "acceptance (ruby ${{ matrix.ruby_version }} | ${{ matrix.os }})"
-    uses: "puppetlabs/cat-github-actions/.github/workflows/gem_acceptance.yml@main"
+          - "windows-latest"
+    name: "spec (${{ matrix.runs_on }} ruby ${{ matrix.ruby_version }} | puppet ${{matrix.puppet_gem_version}})"
+    uses: "puppetlabs/cat-github-actions/.github/workflows/gem_ci.yml@main"
     secrets: "inherit"
     with:
       ruby_version: ${{ matrix.ruby_version }}
-      rake_task: 'acceptance:local_parallel'
-      runs_on: ${{ matrix.os }}
+      puppet_gem_version: ${{ matrix.puppet_gem_version }}
+      runs_on: ${{ matrix.runs_on }}

.rubocop.yml

@@ -0,0 +1,4 @@
+# Silencing rubocop warnings until https://tickets.puppetlabs.com/browse/CONT-725
+# is completed
+AllCops:
+  DisabledByDefault: true

Gemfile

@@ -17,9 +17,9 @@ if RUBY_VERSION =~ /^1\.?9/
   gem 'ffi', '<= 1.9.14'
 end
 
-gem 'rspec', *location_for(ENV['RSPEC_GEM_VERSION'] || '~> 3.0')
-gem 'puppet', *location_for(ENV['PUPPET_GEM_VERSION'] || '~> 7.0')
-gem 'facter', *location_for(ENV['FACTER_GEM_VERSION'] || '~> 4.0')
+gem 'rspec', *location_for(!ENV['RSPEC_GEM_VERSION']&.empty? ? ENV['RSPEC_GEM_VERSION'] : '~> 3.0')
+gem 'puppet', *location_for(!ENV['PUPPET_GEM_VERSION']&.empty? ? ENV['PUPPET_GEM_VERSION'] : '~> 7.0')
+gem 'facter', *location_for(!ENV['FACTER_GEM_VERSION']&.empty? ? ENV['FACTER_GEM_VERSION'] : '~> 4.0')
 gem 'pry', :group => :development
 
 if RUBY_VERSION =~ /^1\.?/

Rakefile

@@ -1,5 +1,6 @@
 require 'rake'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 require 'bundler/gem_tasks'
 require 'fileutils'
 require 'puppet'
@@ -89,3 +90,7 @@ task :test do
     Rake::Task['test:teardown'].invoke
   end
 end
+
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.options = %w[-D -S -E]
+end

spec/classes/test_registry_spec.rb

@@ -1,11 +1,7 @@
 require 'spec_helper'
 
 describe 'test::registry', :if => Puppet.version.to_f >= 4.0 do
-  let(:facts) do
-    {
-      :operatingsystem => 'windows',
-    }
-  end
-
+  let(:facts) { {:os => { :name => 'windows' } } }
+  
   it { should compile.with_all_deps }
 end