Rubocop safe corrections

Author: LukasAud

.rubocop_todo.yml

@@ -6,13 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Severity, Include.
-# Include: **/*.gemspec
-Gemspec/RequireMFA:
-  Exclude:
-    - 'ruby-pwsh.gemspec'
 
 # Offense count: 1
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
@@ -32,19 +25,6 @@ Lint/IncompatibleIoSelectWithFiberScheduler:
   Exclude:
     - 'lib/pwsh.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Lint/RedundantCopDisableDirective:
-  Exclude:
-    - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, consistent
-Lint/SymbolConversion:
-  Exclude:
-    - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
 
 # Offense count: 16
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
@@ -191,11 +171,6 @@ RSpec/SubjectStub:
   Exclude:
     - 'spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/CombinableDefined:
-  Exclude:
-    - 'lib/pwsh.rb'
 
 # Offense count: 1
 # Configuration parameters: AllowedConstants.
@@ -226,11 +201,6 @@ Style/MapIntoArray:
   Exclude:
     - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantFreeze:
-  Exclude:
-    - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).

Gemfile

@@ -14,7 +14,6 @@ def location_for(place_or_version, fake_version = nil)
 end
 
 group :development do
-  gem "json", '= 2.5.1',                         require: false if Gem::Requirement.create(['>= 3.0.0', '< 3.0.5']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
   gem "json", '= 2.6.1',                         require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
   gem "json", '= 2.6.3',                         require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
   gem "deep_merge", '~> 1.0',                    require: false

lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb

@@ -384,8 +384,8 @@ def invoke_get_method(context, name_hash) # rubocop:disable Metrics/AbcSize
     # Canonicalize the results to match the type definition representation;
     # failure to do so will prevent the resource_api from comparing the result
     # to the should hash retrieved from the resource definition in the manifest.
-    data.keys.each do |key| # rubocop:disable Style/HashEachMethods
-      type_key = "dsc_#{key.downcase}".to_sym
+    data.keys.each do |key|
+      type_key = :"dsc_#{key.downcase}"
       data[type_key] = data.delete(key)
 
       # Special handling for CIM Instances
@@ -598,7 +598,7 @@ def logon_failed_already?(credential_hash)
   # @param enumerable [Enumerable] a string, array, hash, or other object to attempt to recursively downcase
   def downcase_hash_keys!(enumerable)
     if enumerable.is_a?(Hash)
-      enumerable.keys.each do |key| # rubocop:disable Style/HashEachMethods
+      enumerable.keys.each do |key|
         name = key.dup.downcase
         enumerable[name] = enumerable.delete(key)
         downcase_hash_keys!(enumerable[name]) if enumerable[name].is_a?(Enumerable)
@@ -1063,7 +1063,7 @@ def escape_quotes(text)
   # With multiple methods which need to discover secrets it is necessary to keep a single regex
   # which can discover them. This will lazily match everything in a single-quoted string which
   # ends with the secret postfix id and mark the actual contents of the string as the secret.
-  SECRET_DATA_REGEX = /'(?<secret>[^']+)+?#{Regexp.quote(SECRET_POSTFIX)}'/.freeze
+  SECRET_DATA_REGEX = /'(?<secret>[^']+)+?#{Regexp.quote(SECRET_POSTFIX)}'/
 
   # Strings containing sensitive data have a secrets postfix. These strings cannot be passed
   # directly either to debug streams or to PowerShell and must be handled; this method contains

lib/pwsh.rb

@@ -68,9 +68,9 @@ def self.instance(cmd, args, options = {})
     #
     # @return [Bool] true if enabled
     def self.win32console_enabled?
-      @win32console_enabled ||= defined?(Win32) &&
-                                defined?(Win32::Console) &&
-                                Win32::Console.instance_of?(Class)
+      @win32console_enabled ||=
+        defined?(Win32::Console) &&
+        Win32::Console.instance_of?(Class)
     end
 
     # TODO: This thing isn't called anywhere and the variable it sets is never referenced...

ruby-pwsh.gemspec

@@ -33,4 +33,5 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.required_ruby_version = Gem::Requirement.new('>= 3.1.0')
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end