more

Author: LukasAud

.rubocop_todo.yml

@@ -201,19 +201,6 @@ Style/MapIntoArray:
   Exclude:
     - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
 
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantRegexpArgument:
-  Exclude:
-    - 'spec/unit/pwsh_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantSelfAssignmentBranch:
-  Exclude:
-    - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
-
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowedMethods, AllowedPatterns.

lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb

@@ -557,7 +557,7 @@ def puppetize_name(name)
     # Puppet module names must only include lowercase letters, digits and underscores
     name = name.gsub(/[^a-z0-9_]/, '_')
     # Puppet module names must not start with a number so if it does, append the letter 'a' to the name. Eg: '7zip' becomes 'a7zip'
-    name = name.match?(/^\d/) ? "a#{name}" : name # rubocop:disable Lint/UselessAssignment
+    name = "a#{name}" if name.match?(/^\d/) # rubocop:disable Lint/UselessAssignment
   end
 
   # Return a UUID with the dashes turned into underscores to enable the specifying of guaranteed-unique

spec/unit/pwsh_spec.rb

@@ -610,7 +610,7 @@ def output_cmdlet(ps_command, ps_args)
         expect(result[:stdout]).to match(/200 OK Glenn/)
         expect(result[:stdout]).to match(/DEBUG: 304 Not Modified James/)
         # then command may have \r\n injected, so remove those for comparison
-        expect(result[:stdout].gsub(/\r\n/, '')).to include(command)
+        expect(result[:stdout].gsub("\r\n", '')).to include(command)
         # and it should end with the Write-Error content
         expect(result[:stdout]).to match(/404 Craig Not Found/)
       end