rubocop unsafe corrections

Author: LukasAud

lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb

@@ -353,7 +353,7 @@ def retry_invoke_dsc_resource(context, max_retry_count, retry_wait_interval_secs
   # @return [Boolean, Void] returns true/false if the resource is/isn't in the desired state and
   #   the validation mode is set to resource, otherwise nil.
   def insync?(context, name, _property_name, _is_hash, should_hash)
-    return nil if should_hash[:validation_mode] != 'resource'
+    return false if should_hash[:validation_mode] != 'resource'
 
     prior_result = fetch_cached_hashes(@cached_test_results, [name])
     prior_result.empty? ? invoke_test_method(context, name, should_hash) : prior_result.first[:in_desired_state]
@@ -787,7 +787,7 @@ def munge_psmodulepath(resource)
   # @return [String] An array of lines of PowerShell to instantiate PSCredentialObjects and store them in variables
   def prepare_credentials(resource)
     credentials_block = []
-    resource[:parameters].each do |_property_name, property_hash|
+    resource[:parameters].each_value do |property_hash|
       next unless property_hash[:mof_type] == 'PSCredential'
       next if property_hash[:value].nil?
 
@@ -822,7 +822,7 @@ def format_pscredential(variable_name, credential_hash)
   # @return [String] An array of lines of PowerShell to instantiate CIM Instances and store them in variables
   def prepare_cim_instances(resource)
     cim_instances_block = []
-    resource[:parameters].each do |_property_name, property_hash|
+    resource[:parameters].each_value do |property_hash|
       next unless property_hash[:mof_is_embedded]
       next if property_hash[:mof_type] == 'PSCredential' # Credentials are handled separately
 
@@ -836,7 +836,7 @@ def prepare_cim_instances(resource)
         cim_instance_hashes.each do |instance|
           variable_name = random_variable_name
           class_name = instance['cim_instance_type']
-          properties = instance.reject { |k, _v| k == 'cim_instance_type' }
+          properties = instance.except('cim_instance_type')
           cim_instances_block << format_ciminstance(variable_name, class_name, properties)
           instantiated_variables.merge!(variable_name => instance)
         end
@@ -950,7 +950,7 @@ def invoke_params(resource) # rubocop:disable Metrics/MethodLength
       params_block = params_block.gsub("#{param_block_name} = @()", "#{param_block_name} = [#{properties[:mof_type]}]@()")
     end
     # HACK: make CIM instances work:
-    resource[:parameters].select { |_key, hash| hash[:mof_is_embedded] && hash[:mof_type].include?('[]') }.each do |_property_name, property_hash|
+    resource[:parameters].select { |_key, hash| hash[:mof_is_embedded] && hash[:mof_type].include?('[]') }.each_value do |property_hash|
       formatted_property_hash = interpolate_variables(format(property_hash[:value]))
       params_block = params_block.gsub(formatted_property_hash, "[CimInstance[]]#{formatted_property_hash}")
     end
@@ -1012,11 +1012,9 @@ def unwrap(value)
       end
       unwrapped
     when Array
-      unwrapped = []
-      value.each do |v|
-        unwrapped << unwrap(v)
+      unwrapped = value.map do |v|
+        unwrap(v)
       end
-      unwrapped
     else
       value
     end
@@ -1037,11 +1035,9 @@ def unwrap_string(value)
       end
       unwrapped
     when Array
-      unwrapped = []
-      value.each do |v|
-        unwrapped << unwrap_string(v)
+      unwrapped = value.map do |v|
+        unwrap_string(v)
       end
-      unwrapped
     else
       value
     end

spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb

@@ -1050,7 +1050,7 @@
 
     let(:name) { { name: 'foo', dsc_name: 'bar' } }
     let(:should_hash) { name.merge(dsc_ensure: 'present') }
-    let(:test_properties) { should_hash.reject { |k, _v| k == :name } }
+    let(:test_properties) { should_hash.except(:name) }
     let(:invoke_dsc_resource_data) { nil }
 
     before do