new todo and some unsafe corrections

Author: LukasAud

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-01-30 16:36:55 UTC using RuboCop version 1.50.2.
+# on 2025-04-09 12:37:11 UTC using RuboCop version 1.70.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -15,7 +15,7 @@ Gemspec/RequireMFA:
     - 'ruby-pwsh.gemspec'
 
 # Offense count: 1
-# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
 Lint/DuplicateBranch:
   Exclude:
     - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
@@ -37,23 +37,23 @@ Lint/IncompatibleIoSelectWithFiberScheduler:
 Metrics/AbcSize:
   Max: 83
 
-# Offense count: 2
+# Offense count: 1
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
 # AllowedMethods: refine
 Metrics/BlockLength:
-  Max: 35
+  Max: 28
 
-# Offense count: 2
+# Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 553
+  Max: 296
 
 # Offense count: 12
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 24
 
-# Offense count: 23
+# Offense count: 22
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 42
@@ -69,6 +69,7 @@ Metrics/PerceivedComplexity:
 # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
 Naming/FileName:
   Exclude:
+    - 'Rakefile.rb'
     - 'lib/ruby-pwsh.rb'
 
 # Offense count: 1
@@ -118,12 +119,12 @@ RSpec/DescribeClass:
     - 'spec/acceptance/dsc/complex.rb'
     - 'spec/unit/pwsh_spec.rb'
 
-# Offense count: 32
+# Offense count: 38
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 70
 
-# Offense count: 105
+# Offense count: 151
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -134,7 +135,7 @@ RSpec/MultipleDescribes:
   Exclude:
     - 'spec/unit/pwsh_spec.rb'
 
-# Offense count: 151
+# Offense count: 157
 RSpec/MultipleExpectations:
   Max: 15
 
@@ -156,14 +157,14 @@ RSpec/NoExpectationExample:
     - 'spec/unit/pwsh/windows_powershell_spec.rb'
     - 'spec/unit/pwsh_spec.rb'
 
-# Offense count: 56
+# Offense count: 86
 RSpec/StubbedMock:
   Exclude:
     - 'spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb'
     - 'spec/unit/pwsh/util_spec.rb'
     - 'spec/unit/pwsh/windows_powershell_spec.rb'
 
-# Offense count: 65
+# Offense count: 71
 RSpec/SubjectStub:
   Exclude:
     - 'spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb'
@@ -175,3 +176,24 @@ Style/Documentation:
     - 'spec/**/*'
     - 'test/**/*'
     - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+# AllowedReceivers: Thread.current
+Style/HashEachMethods:
+  Exclude:
+    - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/HashExcept:
+  Exclude:
+    - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'
+    - 'spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/MapIntoArray:
+  Exclude:
+    - 'lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb'

lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb

@@ -353,7 +353,7 @@ def retry_invoke_dsc_resource(context, max_retry_count, retry_wait_interval_secs
   # @return [Boolean, Void] returns true/false if the resource is/isn't in the desired state and
   #   the validation mode is set to resource, otherwise nil.
   def insync?(context, name, _property_name, _is_hash, should_hash)
-    return nil if should_hash[:validation_mode] != 'resource'
+    return false if should_hash[:validation_mode] != 'resource'
 
     prior_result = fetch_cached_hashes(@cached_test_results, [name])
     prior_result.empty? ? invoke_test_method(context, name, should_hash) : prior_result.first[:in_desired_state]

spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb

@@ -416,7 +416,7 @@
       it 'does not call invoke_test_method and returns nil' do
         expect(provider).not_to receive(:fetch_cached_hashes)
         expect(provider).not_to receive(:invoke_test_method)
-        expect(provider.send(:insync?, context, name, attribute_name, is_hash, should_hash_validate_by_property)).to be_nil
+        expect(provider.send(:insync?, context, name, attribute_name, is_hash, should_hash_validate_by_property)).to be false
       end
     end
   end