Skip to content

Commit 808260d

Browse files
authored
Merge branch 'main' into dependabot/docker/docker/jruby-9.4.7.0-jdk11
2 parents a4c9d2b + 683e1e6 commit 808260d

File tree

9 files changed

+127
-62
lines changed

9 files changed

+127
-62
lines changed

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,23 @@
11
# Changelog
22

3+
## [3.8.1](https://github.com/puppetlabs/vmpooler-deployment/tree/3.8.1) (2024-07-08)
4+
5+
[Full Changelog](https://github.com/puppetlabs/vmpooler-deployment/compare/3.7.0...3.8.1)
6+
7+
**Implemented enhancements:**
8+
9+
- \(RE-15696\) Local Development - Add Grafana and remove redis mount [\#147](https://github.com/puppetlabs/vmpooler-deployment/pull/147) ([yachub](https://github.com/yachub))
10+
11+
**Fixed bugs:**
12+
13+
- vsphere [\#153](https://github.com/puppetlabs/vmpooler-deployment/issues/153)
14+
15+
**Merged pull requests:**
16+
17+
- \(maint\) empty commit for redeploy attempt [\#155](https://github.com/puppetlabs/vmpooler-deployment/pull/155) ([e-gris](https://github.com/e-gris))
18+
- RE-16207: Create a 3.8.0 release / script cleanup [\#154](https://github.com/puppetlabs/vmpooler-deployment/pull/154) ([e-gris](https://github.com/e-gris))
19+
- Bump jruby from 9.4.3.0-jdk11 to 9.4.5.0-jdk11 in /docker [\#149](https://github.com/puppetlabs/vmpooler-deployment/pull/149) ([dependabot[bot]](https://github.com/apps/dependabot))
20+
321
## [3.7.0](https://github.com/puppetlabs/vmpooler-deployment/tree/3.7.0) (2023-10-05)
422

523
[Full Changelog](https://github.com/puppetlabs/vmpooler-deployment/compare/3.6.0...3.7.0)

README.md

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
- [Contributing](#contributing)
1313
- [License](#license)
1414

15-
This repo contains Dockerfiles and a Helm chart that can be used to deploy [VMPooler](https://github.com/puppetlabs/vmpooler). The Release Engineering team at Puppet uses the code here as part of operating our VMPooler instances.
15+
Contains Dockerfiles and a Helm chart that are used to deploy [VMPooler](https://github.com/puppetlabs/vmpooler).
1616

1717
## VMPooler Components
1818

19-
The docker image gnerated and hosted by this project contain the following VMPooler components:
19+
The docker image contains these VMPooler components:
2020

2121
- [VMPooler Core](https://github.com/puppetlabs/vmpooler)
2222
- [VMPooler Google CloudDNS Plugin](https://github.com/puppetlabs/vmpooler-dns-google-clouddns)
@@ -26,34 +26,34 @@ The docker image gnerated and hosted by this project contain the following VMPoo
2626

2727
## Docker Registry
2828

29-
The GitHub Actions in this repository publish images to GitHub Packages. You can browse the VMPooler containers [here](https://github.com/puppetlabs/vmpooler-deployment/pkgs/container/vmpooler-deployment%2Fvmpooler).
29+
GitHub Actions publishes images to GitHub Packages. Browse the VMPooler containers: https://github.com/puppetlabs/vmpooler-deployment/pkgs/container/vmpooler-deployment%2Fvmpooler
3030

31-
The vmpooler officially released docker image tags use a semantic version, where the version increments correlate to the increments in any of the gems at `docker/Gemfile`.
31+
The vmpooler released docker image tags use semantic versioning; the version increments correlate to the increments in any of the gems at `docker/Gemfile`.
3232

3333
Image tags starting with `pr<PULL REQUEST NUMBER>-<GIT SHA>` are generated when opening and pushing to a pull request and will periodically be cleaned up.
3434

3535
## Helm Repository
3636

37-
The `docs/` folder in this repository represents a Helm repository served via GitHub Pages at https://puppetlabs.github.io/vmpooler-deployment/
37+
The `docs` folder represents a Helm repository served via GitHub Pages at https://puppetlabs.github.io/vmpooler-deployment
3838

3939
```bash
40-
$ helm repo add vmpooler-deployment https://puppetlabs.github.io/vmpooler-deployment/
40+
$ helm repo add vmpooler-deployment https://puppetlabs.github.io/vmpooler-deployment
4141
"vmpooler-deployment" has been added to your repositories
4242
```
4343

4444
### Adding / updating charts
4545

46-
Make the desired changes to the helm chart in helm-charts/vmpooler and run `./update-chart`.
46+
Update the helm chart in helm-charts/vmpooler. Run `./update-chart`.
4747

4848
## Development
4949

5050
Prerequisites:
5151

52-
- [Docker](https://docs.docker.com/engine/install/)
53-
- [Docker Compose](https://docs.docker.com/compose/install/)
52+
- [Docker](https://docs.docker.com/engine/install)
53+
- [Docker Compose](https://docs.docker.com/compose/install)
5454

5555
1. Become familiar with the configuration file `docker/vmpooler.yaml` as described in [VMPooler](https://github.com/puppetlabs/vmpooler) Core.
56-
- The default configuration file only enables the dummy provider built into [VMPooler](https://github.com/puppetlabs/vmpooler) Core. See each project below for documentation on how to use provider specific options:
56+
- The default configuration file enables the dummy provider built into [VMPooler](https://github.com/puppetlabs/vmpooler) Core. See each project for documentation on how to use provider specific options:
5757
- [vmpooler-provider-ec2](https://github.com/puppetlabs/vmpooler-provider-ec2)
5858
- [vmpooler-provider-gce](https://github.com/puppetlabs/vmpooler-provider-gce)
5959
- [vmpooler-provider-vsphere](https://github.com/puppetlabs/vmpooler-provider-vsphere)
@@ -81,11 +81,11 @@ Prerequisites:
8181
3. Run `./update-gemfile-lock` to update the `Gemfile.lock`
8282
4. Run `docker compose build && docker compose up`.
8383

84-
When a dependency Helm chart is updated, be sure to run `./update-chart-lock` to update the lockfile, otherwise the test and release workflows will fail.
84+
When a dependency Helm chart is updated, always run `./update-chart-lock` to update the lockfile, otherwise the test and release workflows will fail.
8585

8686
### Docker Compose URLs
8787

88-
These are the default ports used in the docker compose file, to change them edit the `ports` key under the desired service in either `docker/docker-compose.yml` or `docker/docker-compose.local.yml`.
88+
These are the default ports used in the docker compose file. To change them edit the `ports` key under the service in either `docker/docker-compose.yml` or `docker/docker-compose.local.yml`.
8989

9090
Tracing data is sent to the Jaeger instance, a prometheus server scrapes metrics, and both are pre-configured in Grafana as datasources for easy visualization and history of data.
9191

@@ -115,22 +115,18 @@ Artifactory Example:
115115

116116
Create a GitHub tag and release, publish a new docker image, and helm chart by opening a release prep pull request and running the release action below.
117117

118-
**NOTE**: Due to the GitHub limitation that does not allow any method of bypassing status checks on a protected branch, the process below will technically publish the helm chart pointing to a nonexistent docker tag until the release workflow is run.
118+
**NOTE**: Due to the GitHub limitation that does not allow any method of bypassing status checks on a protected branch, the process below will publish the helm chart pointing to a nonexistent docker tag until the release workflow is run.
119119

120-
1. Bump the "appVersion" key in `helm-charts/vmpooler/Chart.yaml` appropriately based on changes to `docker/Gemfile` and `docker/Gemfile.lock` in merged pull requests since the last release.
120+
1. Increment the "appVersion" key in `helm-charts/vmpooler/Chart.yaml` appropriately based on changes to `docker/Gemfile` and `docker/Gemfile.lock` in merged pull requests since the last release.
121121
- This key pertains to the docker tag that will be pushed upon release.
122-
2. Bump the "version" key in `helm-charts/vmpooler/Chart.yaml` appropriately based on changes to the chart itself and increments of the "appVersion" in merged pull requests since the last release.
122+
2. Increment the "version" key in `helm-charts/vmpooler/Chart.yaml` appropriately based on changes to the chart itself and increments of the "appVersion" in merged pull requests since the last release.
123123
- This key pertains to the helm chart verison that will be pushed upon release.
124124
3. Run `./update-changelog` to update `CHANGELOG.md`.
125125
4. Run `./build-chart` to package the new chart and update the repo index.
126-
5. Commit and push changes to a new branch, then open a pull request against `main` and be sure to add the "maintenance" label.
126+
5. Commit and push changes to a new branch then open a pull request against `main` and be sure to add the "maintenance" label.
127127
6. After the pull request is approved and merged, then navigate to Actions --> Docker and Helm Release --> run workflow --> Branch: main --> Run workflow.
128128
- This action will push a tagged docker image to the GitHub container registry and helm chart to GitHub pages.
129129

130-
## Contributing
131-
132-
We welcome and encourage contributions!
133-
134130
## License
135131

136132
vmpooler-deployment is distributed under the [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.html). See the [LICENSE](LICENSE) file for more details.

build-chart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
#!/usr/bin/env bash
22

3-
docker run --rm -it -v $(pwd):/apps --entrypoint /bin/sh alpine/helm \
4-
-c 'helm repo add bitnami https://charts.bitnami.com/bitnami && cd /apps/helm-charts/vmpooler && helm dependency update && cd /apps/docs && helm package ../helm-charts/* && helm repo index --url https://puppetlabs.github.io/vmpooler-deployment/ .'
3+
set -e
4+
set -x
5+
6+
docker run --rm --interactive --tty --volume=$(pwd):/apps \
7+
--entrypoint /bin/sh alpine/helm ./helm-package

0 commit comments

Comments
 (0)