add functional test for SecretServiceKeychainAccess

Author: infeo

src/test/java/org/cryptomator/linux/keychain/SecretServiceKeychainAccessTest.java

@@ -1,25 +1,33 @@
 package org.cryptomator.linux.keychain;
 
+import org.cryptomator.integrations.keychain.KeychainAccessException;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
 import org.junit.jupiter.api.condition.EnabledIf;
+import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
 
 import java.io.IOException;
 import java.util.List;
+import java.util.UUID;
 import java.util.concurrent.TimeUnit;
 
 /**
  * Unit tests for GNOME keyring access via DBUS.
  */
+@EnabledIfEnvironmentVariable(named = "DISPLAY", matches = ".*")
 public class SecretServiceKeychainAccessTest {
 
 	private static boolean isInstalled;
 
 	@BeforeAll
 	public static void checkSystemAndSetup() throws IOException {
 		ProcessBuilder dbusSend = new ProcessBuilder("dbus-send", "--print-reply", "--dest=org.freedesktop.DBus", "/org/freedesktop/DBus", "org.freedesktop.DBus.ListNames");
-		ProcessBuilder grep = new ProcessBuilder("grep", "org.gnome.keyring");
+		ProcessBuilder grep = new ProcessBuilder("grep", "-q", "org.gnome.keyring");
 		try {
 			Process end = ProcessBuilder.startPipeline(List.of(dbusSend, grep)).get(1);
 			if (end.waitFor(1000, TimeUnit.MILLISECONDS)) {
@@ -32,15 +40,51 @@ public static void checkSystemAndSetup() throws IOException {
 		}
 	}
 
-
 	@Test
-	@EnabledIf("isXdgDisplayEnvVarSet")
 	public void testIsSupported() {
-		SecretServiceKeychainAccess secretService = new SecretServiceKeychainAccess();
-		Assertions.assertEquals(isInstalled, secretService.isSupported());
+		var gnomeKeyring = new SecretServiceKeychainAccess();
+		Assertions.assertEquals(isInstalled, gnomeKeyring.isSupported());
 	}
 
-	public boolean isXdgDisplayEnvVarSet() {
-		return System.getenv("DISPLAY") != null;
+	@Nested
+	@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+	@EnabledIf("gnomeKeyringAvailableAndUnlocked")
+	class FunctionalTests {
+
+		static final String KEY_ID = "cryptomator-test-" + UUID.randomUUID();
+		final SecretServiceKeychainAccess gnomeKeyring = new SecretServiceKeychainAccess();
+
+		@Test
+		@Order(1)
+		public void testStore() throws KeychainAccessException {
+			gnomeKeyring.storePassphrase(KEY_ID, "cryptomator-test", "p0ssw0rd");
+		}
+
+		@Test
+		@Order(2)
+		public void testLoad() throws KeychainAccessException {
+			var passphrase = gnomeKeyring.loadPassphrase(KEY_ID);
+			Assertions.assertNotNull(passphrase);
+			Assertions.assertEquals("p0ssw0rd", String.copyValueOf(passphrase));
+		}
+
+		@Test
+		@Order(3)
+		public void testDelete() throws KeychainAccessException {
+			gnomeKeyring.deletePassphrase(KEY_ID);
+		}
+
+		@Test
+		@Order(4)
+		public void testLoadNotExisting() throws KeychainAccessException {
+			var result = gnomeKeyring.loadPassphrase(KEY_ID);
+			Assertions.assertNull(result);
+		}
+
+		public static boolean gnomeKeyringAvailableAndUnlocked() {
+			var secretServiceKeychain = new SecretServiceKeychainAccess();
+			return secretServiceKeychain.isSupported() && !secretServiceKeychain.isLocked();
+		}
 	}
+
 }